Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added postRequest method #4

Merged
merged 24 commits into from
Mar 23, 2021
Merged

added postRequest method #4

merged 24 commits into from
Mar 23, 2021

Conversation

Aras14HD
Copy link
Contributor

@Aras14HD Aras14HD commented Mar 3, 2021

No description provided.

delightedCrow
delightedCrow requested changes Mar 9, 2021
View reviewed changes
Copy link
Owner

@delightedCrow delightedCrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried testing your POST request against any of the HabiticaAPI's endpoints?

src/HabiticaAPIManager.js Outdated Show resolved Hide resolved
@Aras14HD Aras14HD mentioned this pull request Mar 11, 2021
Closed
@Aras14HD Aras14HD marked this pull request as draft March 12, 2021 09:29
@Aras14HD Aras14HD marked this pull request as ready for review March 12, 2021 11:16
delightedCrow
delightedCrow requested changes Mar 12, 2021
View reviewed changes
Copy link
Owner

@delightedCrow delightedCrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent start.

We do need to keep the /docs directory though - I'd recommend just modifying the README.md and src/HabiticaAPIManager.js files for this PR.

.gitignore Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/HabiticaAPIManager.js Outdated Show resolved Hide resolved
@delightedCrow delightedCrow merged commit 6ddb302 into delightedCrow:dev Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delightedCrow delightedCrow delightedCrow requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Aras14HD @delightedCrow @deepsourcebot