91/CI performance assert fix #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenwalsh
approved these changes
Sep 21, 2020
rawstorage
pushed a commit
that referenced
this pull request
Aug 12, 2022
91/CI performance assert fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request addresses a scenario in certain performance calls where response code 200 is returned even when there are no results returned. This leads to failed tests because CI base functions will look at response codes to determine if a call was successful.
This fix adds a check in the base function for performance asserts that will check if a key list is empty before continuing, if it is empty the test will skip in the same fashion as those categories which return status code for no results.