Changes to support CSM-523, some PowerScale Replication cleanup #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovements w.r.t SyncIQ policy
…fficially supported
ChristianAtDell
requested review from
Deepak-Ghivari,
gallacher,
mjsdell,
prablr79,
rajendraindukuri,
rajkumar-palani,
rsedlock1958 and
shanmydell
as code owners
santhoshatdell
previously approved these changes
Jan 18, 2023
| @@ -136,7 +136,7 @@ Let's go through each parameter and what it means: | |||
|
|
|||
| * `Accesszone` is the name of the access zone a volume can be created in. | |||
| * `AzServiceIP` AccessZone groupnet service IP. It is optional and can be provided if different than the PowerScale cluster endpoint. | |||
| * `IsiPath` is the base path for the volumes to be created on the PowerScale cluster. | |||
| * `IsiPath` is the base path for the volumes to be created on the PowerScale cluster. If not specified in the storage class, the IsiPath defined in the storage array's secret will be used, and if that is not specified, the IsiPath defined in the values.yaml file used for driver installation is used as the lowest-priority. IsiPath between source and target Replication Groups MUST be consistent. | |||
There was a problem hiding this comment.
MUST to highlighted must in lower case.
| This singular SyncIQ policy on the source storage array and its matching Local Target policy on the target storage array provide information for the RGs to determine their status. Upon creation, the SyncIQ policy is set to a schedule of `When source is modified`. The SyncIQ policy is `Enabled` when the RG is created. The directory that is being replicated is *read-write accessible* on the source storage array, and is restricted to *read-only* on the target. | ||
|
|
||
| ### Replication Group Deletion | ||
| When deleting `DellCSIReplicationGroup` (RG) objects on the Kubernetes cluster(s) used for replication, deletion should only be performed on an empty RG. If there is any user-created or Kubernetes PV-generated data left inside of the replication group, the RG object will be held in a `Deleting` state until all user data has been cleared out. |
There was a problem hiding this comment.
Should we say 'until all user data has been cleared out on both source and target storage arrays' ?
harshaatdell
previously approved these changes
Jan 18, 2023
ChristianAtDell
dismissed stale reviews from harshaatdell and santhoshatdell
via
98475de
| @@ -136,7 +136,7 @@ Let's go through each parameter and what it means: | |||
|
|
|||
| * `Accesszone` is the name of the access zone a volume can be created in. | |||
| * `AzServiceIP` AccessZone groupnet service IP. It is optional and can be provided if different than the PowerScale cluster endpoint. | |||
| * `IsiPath` is the base path for the volumes to be created on the PowerScale cluster. | |||
| * `IsiPath` is the base path for the volumes to be created on the PowerScale cluster. If not specified in the storage class, the IsiPath defined in the storage array's secret will be used, and if that is not specified, the IsiPath defined in the values.yaml file used for driver installation is used as the lowest-priority. IsiPath between source and target Replication Groups MUST be consistent. | |||
There was a problem hiding this comment.
Remove the comma and place a period (.") after "will be used". Delete "and" and make "if" upper case to start a new sentence,
|
Forgot the period in my last commit, sorry. Should be good now. |
harshaatdell
approved these changes
Jan 18, 2023
rsedlock1958
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional text has been added for RG deletion information in PowerScale (see the Deletion subheading in content/docs/replication/architecture/powerscale.md), and IsiPath parameter description has been expanded to make requirements/functionality clearer.
A child page under Architecture was also created for PowerScale, and PowerScale-specific information has been moved from the PowerScale Deployment page to this child page. The Deployment page was beginning to get cluttered with non-deployment PowerScale information.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: