Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support k8s 1.26 #153

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Support k8s 1.26 #153

merged 3 commits into from
Jan 17, 2023

Conversation

panigs7
Copy link
Collaborator

@panigs7 panigs7 commented Jan 13, 2023

Description

Add support for k8s 1.26

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#597

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Sanity test -> installed csm-operator followed by driver installation
image

@@ -21,7 +21,4 @@ images:

# "images.externalhealthmonitorcontroller" defines the container images used for the csi external health monitor controller
# container.
externalhealthmonitorcontroller: k8s.gcr.io/sig-storage/csi-external-health-monitor-controller:v0.7.0

# "images.sdcmonitor" defines the container images used to monitor sdc container
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panigs7 sdcmonitor related sample is deleted. Please check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it.

karthikk92
karthikk92 previously approved these changes Jan 17, 2023
Copy link
Contributor

@rensyct rensyct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the deleted files as csm-operator supports n-2 versions of the driver. driver v2.4 has K8s 1.21 and 1.22 in the support matrix

Done

@rensyct rensyct merged commit 0f6ed60 into main Jan 17, 2023
@rensyct rensyct deleted the feature-k8s1.26-support branch July 17, 2023 12:16
ChristianAtDell added a commit that referenced this pull request Oct 15, 2024
* Support k8s 1.26

* sdc sidecar

* Reverting configfiles since n-2 driver is supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants