Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Allow FQDN for the endpoint in CSI-PowerStore #731

Closed
AkshaySainiDell opened this issue Mar 28, 2023 · 2 comments
Closed

[FEATURE]: Allow FQDN for the endpoint in CSI-PowerStore #731

AkshaySainiDell opened this issue Mar 28, 2023 · 2 comments
Assignees
Labels
area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore needs-triage Issue requires triage. type/feature-request New feature request. This is the default label associated with a feature request issue.
Milestone

Comments

@AkshaySainiDell
Copy link
Contributor

AkshaySainiDell commented Mar 28, 2023

Describe the solution you'd like
I'm with a customer trying deploy the CSI Driver for PowerStore. We configure the endpoint with a DNS name and I have the error :

Read CSI_LOG_LEVEL from log configuration file, level: debug
{"level":"info","msg":"updating array info","time":"2023-03-16T13:07:00.661953233Z"}
{"level":"fatal","msg":"couldn't initialize arrays in node service: can't get config for arrays: can't get ips from endpoint: https://<domain-name>.com/api/rest","time":"2023-03-16T13:07:00.662665873Z"}

From what I see here : https://github.com/dell/csi-powerstore/blob/64be9636f7a0a525ec656bf43467da95fb922b37/pkg/array/array.go#L230 it looks like we are asking for an IP address.
Why is that ?

It is a bit of a concern for several reasons :

  • A certificate is almost always issue against a DNS name(s) and rarely on an IP address. And I don't think we can have a trusted certificate by a CA on a private IP
  • If we have to connect through a load-balancer, or if the IP of the PS changes, it can be an issue to use an IP over an FQDN
@AkshaySainiDell AkshaySainiDell added needs-triage Issue requires triage. type/feature-request New feature request. This is the default label associated with a feature request issue. labels Mar 28, 2023
@csmbot
Copy link
Collaborator

csmbot commented Mar 28, 2023

@AkshaySainiDell: Thank you for submitting this issue!

The issue is currently awaiting triage. Please make sure you have given us as much context as possible.

If the maintainers determine this is a relevant issue, they will remove the needs-triage label and assign an appropriate priority label.


We want your feedback! If you have any questions or suggestions regarding our contributing process/workflow, please reach out to us at container.storage.modules@dell.com.

@AkshaySainiDell AkshaySainiDell added the area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore label Mar 28, 2023
@adarsh-dell
Copy link
Contributor

The necessary modifications for this feature have been incorporated into the main branch. Starting from version 2.7.0, the PowerStore driver will support it.

@adarsh-dell adarsh-dell added this to the v1.7.0 milestone Apr 25, 2023
csmbot pushed a commit that referenced this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/csi-powerstore Issue pertains to the CSI Driver for Dell EMC PowerStore needs-triage Issue requires triage. type/feature-request New feature request. This is the default label associated with a feature request issue.
Projects
None yet
Development

No branches or pull requests

3 participants