Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the K8s1.22 Support and added K8s 1.23 support for OCP - Powerscale driver #127

Merged
merged 5 commits into from
Feb 20, 2023

Conversation

rajkumar-palani
Copy link
Contributor

Description

Removed the K8s1.22 Support for the latest Power Scale Driver (2.6.0)

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#597

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Driver Installation and PVC Creation - Sanity
    Nodes:
    image

Driver Installation:
image

PVC:
image

PVC in OneFS:
image

  • Snapshot - Sanity

image

Snapshot in OneFS:
image

  • PVC From Snapshot - Sanity
    image

  • Backward Compatibility Check - Sanity

Operator Execution:
image

Driver Installation:
image

Storage Class:
image

PVC:
image

@rensyct
Copy link
Contributor

rensyct commented Feb 17, 2023

@rajkumar-palani , Please add configs and samples for 1.23 in 2.6 as OCP 4.10 uses K8s 1.23

@rajkumar-palani rajkumar-palani changed the title Removed the K8s1.22 Support for the Latest version of Powerscale driver Removed the K8s1.22 Support and added K8s 1.23 support for OCP - Powerscale driver Feb 17, 2023
@rajkumar-palani
Copy link
Contributor Author

@rajkumar-palani , Please add configs and samples for 1.23 in 2.6 as OCP 4.10 uses K8s 1.23

@rensyct I have added it. Thank you.

@@ -143,18 +143,12 @@ spec:
# Allowed values: map of key-value pairs
# Default value: None
nodeSelector:
# Uncomment if nodes you wish to use have the node-role.kubernetes.io/master taint
# node-role.kubernetes.io/master: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K8s 1.23 has examples for master under node selector and tolerations. Please revert the changes made in this file wrt examples for master under node selector and tolerations

rensyct
rensyct previously approved these changes Feb 20, 2023
@nitesh3108 nitesh3108 merged commit 81748c2 into main Feb 20, 2023
@nitesh3108 nitesh3108 deleted the feature-10202-powerscale-k8s-1.22-removal branch February 20, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants