Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings for modules with no version #291

Merged
merged 2 commits into from
Jan 3, 2023
Merged

Conversation

xuzhen
Copy link
Collaborator

@xuzhen xuzhen commented Dec 29, 2022

If there is no MODULE_VERSION() macro used in a module's source code, modinfo will not show the version: xxxx field for the compiled binary.

if MODULE_VERSION("") is used, the situation is similar. modinfo will only show version: for the compiled binary.

In both cases, dkms status will report WARNING! Diff between built and installed module! and dkms uninstall will say Module was not found within /lib/modules/$kernelver/ and the the module will not be removed.

Fix #290
`

@freswa
Copy link
Contributor

freswa commented Jan 1, 2023

I can confirm this fixes #290 for Arch Linux too.

@scaronni
Copy link
Collaborator

scaronni commented Jan 3, 2023

Fixes the same issue on Fedora too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

module version check causes WARNING build vs. install
3 participants