Consistently use install_tree, allow overriding /lib/modules #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's a very good idea! Shall we merge and create a new release with all the recent changes? |
|
Yup, my plan was to make a release soonish - the next week or so. Was just checking when the kmod team will do a release on their end (with similar feature). |
We should be aiming at the former, since it's the toggle the user can override. Seemingly none of our tests do, so this went under the radar. Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
We're going to add more patterns to replace soon, across multiple files. So avoid adding even more duplication. Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Swap for the more common s,@foobar@,$(BAZ),g sed pattern. Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
With many distributions moving from /lib/modules to /usr/lib/modules, allow for the builder to select their option. For backwards compatibility the default is still /lib/modules. As result distros for example Arch don't need to patch the project. Plus this nicely aligns with kmod, which recently allowed for similar change. Note: the tests still use the original path. If needed that can be changed as follow-up. Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
evelikov
force-pushed
the
usr-lib-modules
branch
from
3b0f84f
to
978087b
Compare
|
Rebasing this was a bit more fiddly than I expected. So I will be merging this as the CI completes. With kmod release expected in a week or two, I am aiming to do dkms shortly afterwards - especially since without #390 modules can fail to load. If anyone has comments or concerns - please raise them at any point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With many distributions moving from /lib/modules to /usr/lib/modules,
allow for the builder to select their option. For backwards
compatibility the default is still /lib/modules.
As result distros for example Arch don't need to patch the project.
Plus this nicely aligns with kmod, which recently allowed for similar
change.
To override set the MODDIR variable during make.
@scaronni @anbe42 @seblu happy to hear if you have any concerns about this.
Fwiw kmod has landed /usr/lib/modules support with this series, although the last release v31 was just prior to that work.