Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SDC Name function added #17

Closed
wants to merge 18 commits into from
Closed

Change SDC Name function added #17

wants to merge 18 commits into from

Conversation

AnshumanPradipPatil1506
Copy link
Contributor

@AnshumanPradipPatil1506 AnshumanPradipPatil1506 commented Dec 6, 2022 •
edited
Loading

Description

  • Change SDC name Function added for terraform provider creation related to SDC resource.
  • Added testcases for Change SDC name Function.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • [✓] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • [✓] I have verified that new and existing unit tests pass locally with my changes
  • [✓] I have not allowed coverage numbers to degenerate
  • [✓] I have maintained at least 90% code coverage
  • [✓] I have commented my code, particularly in hard-to-understand areas
  • [✓] I have made corresponding changes to the documentation
  • [✓] I have added tests that prove my fix is effective or that my feature works
  • [✓] Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • [✓] Test TestChangeSdcName
  • [✓] Test - Run all testcases with sh run-integration.sh and compared results -> before change with after change

root and others added 13 commits November 24, 2022 00:40
create template fuction added
b7da1cc
@AnshumanPradipPatil1506
Merge branch 'main' of https://github.com/AnshumanPradipPatil1506/gos…
a44472d 
…caleio into main
@AnshumanPradipPatil1506
CRUD op completed
dcb8c44
@AnshumanPradipPatil1506
mod files restored
7eebb3f
@AnshumanPradipPatil1506
fixed referances
146375b
@AnshumanPradipPatil1506
Update api.go
c21d15a
@AnshumanPradipPatil1506
template types added
0acf97b
@AnshumanPradipPatil1506
resolved conflicts
e5096c2
@AnshumanPradipPatil1506
Delete mypatch.patch
6003dde
@AnshumanPradipPatil1506
removed logs from debugging
d03cdde
@AnshumanPradipPatil1506
Merge branch 'main' of https://github.com/AnshumanPradipPatil1506/gos…
fbbd78c 
…caleio into main
@AnshumanPradipPatil1506
added name change feature for sdc
de64330
@AnshumanPradipPatil1506
added testcases for sdc name chng function
2ce58d2 
updated the goversion. (dell#15)

updated the sys package. (dell#16)

added back links to goscaleio/dell

removed template feature for merge

removed unwanted functions

removed links function bypass

added code comments

removed local env file
khareRajshree
khareRajshree requested changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@khareRajshree khareRajshree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add signed/verified commits.

sdc.go Outdated Show resolved Hide resolved
VamsiSiddu-7
VamsiSiddu-7 reviewed Dec 13, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@AnshumanPradipPatil1506
Deleted go.mod
1ce6229 
Deleted go.mod which is already present
@AnshumanPradipPatil1506
resolved PR suggestions
84215e2
VamsiSiddu-7
VamsiSiddu-7 suggested changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes needed please do that Thanks

sdc.go Show resolved Hide resolved
go.mod Show resolved Hide resolved
@AnshumanPradipPatil1506
Copy link
Contributor Author

Raising new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VamsiSiddu-7 VamsiSiddu-7 VamsiSiddu-7 requested changes

@khareRajshree khareRajshree khareRajshree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnshumanPradipPatil1506 @khareRajshree @VamsiSiddu-7