[TFM-231] Terrafrom : Adding Snapshot Retention Param #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krishnan-Priyanshu
changed the title
Krishnan-Priyanshu
requested review from
khareRajshree,
VamsiSiddu-7 and
shenda1
VamsiSiddu-7
suggested changes
Jan 5, 2023
| } | ||
|
|
||
| // SetSnapshotSecurity set retention period in min on snapshot | ||
| func (v *Volume) SetSnapshotSecurity(retentionPeriodInMin string) error { |
There was a problem hiding this comment.
are the unit tests covered for this new function?
There was a problem hiding this comment.
added the unit test
khareRajshree
approved these changes
Jan 5, 2023
VamsiSiddu-7
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding RetentionLimit to snapshot
Adding functionality to set snapshot security which takes retention perion in min as value
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Also created a unit test to test this functionality
Ran Integration test
