Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chart csi-isilon] add ability to set priorityclassname to controller and node #385

Closed
wants to merge 3 commits into from

Conversation

SebPlv
Copy link

@SebPlv SebPlv commented Mar 19, 2024

Is this a new chart?

No

What this PR does / why we need it:

This PR adds the ability to set a PriorityClassName to de Controller deployment and the Node Daemonset of csi-isilon.

Which issue(s) is this PR associated with:

None

Special notes for your reviewer:

Checklist:

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the chart README.md
  • Title of the PR starts with the chart name (e.g. [charts_dir/mychartname]) if applicable

Copy link
Collaborator

@coulof coulof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @SebPlv !

I understand you need the priorityClassName but I'm not sure this is widely adopted.

While waiting for the engineering review, I can suggest that you use Kustomize to patch the helm chart.

You can find an example in context of this patch here : https://gist.github.com/coulof/aacc92e4a95cff85d5c5693aedb7c980

And more details on why it can be a good solution here : https://storage-chaos.io/kustomize-and-helm-better-together.html

@coulof coulof closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants