Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][Ticket #900284] Investigate metadata delay in case western #2816

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

K4rishma
Copy link
Contributor

@K4rishma K4rishma commented Jul 4, 2024

Update: overview acquisition worked after waiting for the stage position to reach the target position.

Testing on 9th July

Please let me know where I can add logging to understand the metadata issue at Case Western.

Objective:

  1. understand the source or where the delay occurs in saving the tiled images
  2. try to make the overview images work by adding time delay if source of metadata issue is not clear

@patrickcleeve2
Copy link
Contributor

patrickcleeve2 commented Jul 5, 2024

Looks good to me. One note is that the additionally logging may slow things down enough that they are synced up, so might be hard to re-create.

Also, instead of adding an artificial display, you can force update the metadata with the stage position

das[0].metadata[model.MD_POS] = stage.position.value["x"], stage.position.value["y"]

@pieleric
Copy link
Member

pieleric commented Jul 5, 2024

You'll need to also compare to the updated stage position by xt_client (in /var/log/odemis.log), see Updated position to.... And check the messages before, related to the stage movement. After the move it should always say "Stage move completed".
You also might want to add a log in actuators.ConvertStage._updatePosition() (which is called when the raw stage position changes) and look for "reporting position" corresponding to the MultiplexActuator.
Finally, you want to look for "Updating position for component..." from the mdupdater that is supposed to copy the stage position onto the ccd metadata (as MD_POS). All of this should happen before the image acquisition starts (although I don't think there is any code that ensures this is the case...)

@K4rishma K4rishma changed the title [Bug] Investigate metadata delay in case western [Bug][Ticket #900284] Investigate metadata delay in case western Jul 9, 2024
@K4rishma K4rishma changed the title [Bug][Ticket #900284] Investigate metadata delay in case western [fix][Ticket #900284] Investigate metadata delay in case western Jul 24, 2024
@K4rishma K4rishma marked this pull request as ready for review July 24, 2024 14:08
@K4rishma K4rishma requested a review from pieleric July 24, 2024 14:08
Copy link
Contributor

@patrickcleeve2 patrickcleeve2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor cleanup

src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
@K4rishma K4rishma marked this pull request as draft July 29, 2024 09:14
@K4rishma K4rishma requested review from tepals and removed request for pieleric August 12, 2024 13:23
@K4rishma K4rishma marked this pull request as ready for review August 12, 2024 13:26
@tepals
Copy link
Contributor

tepals commented Aug 12, 2024

Can you fix the linting?

src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
@K4rishma K4rishma requested review from pieleric and removed request for patrickcleeve2 August 26, 2024 14:22
@K4rishma K4rishma requested review from patrickcleeve2 and removed request for patrickcleeve2 August 26, 2024 14:34
src/odemis/driver/xt_client.py Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Outdated Show resolved Hide resolved
src/odemis/driver/xt_client.py Show resolved Hide resolved
Copy link
Contributor

@patrickcleeve2 patrickcleeve2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment

src/odemis/driver/xt_client.py Show resolved Hide resolved
@pieleric pieleric merged commit be8c860 into delmic:master Sep 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants