Fix Regression Failures; Type Error Handling Improvements; Strict Type Checking Updates #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was recent work in drgn where all the helpers were annotated with types. With that work in place we no longer need to allow untyped calls.
As we know, drgn type equality does not work right, so we need to compare canonicalized type names. When combined with openzfs/zfs#10236, `zfs_dbgmsg` now works on ztest core dumps. Serapheim Note: With drgn changing its type rules once again this commit is now needed for existing tests to not fail.
drgn recently updated its error messages when it comes to page table lookups to match the latest terminology used by the kernel.
In the past we used to assume lazy type rules from drgn and printing an anonymous union or struct from its typedef just worked. Unfortunately, with the latest updates for types in drgn, this no longer works so part of this commit removes the expectation of this functionality from our tests. We may want to introduce this functionality again in the future implemented in a different way. Fortunately, these kind of types are rare. The second part of this commit improves the error handling of looking up types.
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 87.38% 87.37% -0.01%
==========================================
Files 60 60
Lines 2473 2488 +15
==========================================
+ Hits 2161 2174 +13
- Misses 312 314 +2
Continue to review full report at Codecov.
|
prakashsurya
approved these changes
Oct 12, 2020
pzakha
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1
mypy: disallow untyped calls for the sdb directory
There was recent work in drgn where all the helpers were annotated
with types. With that work in place we no longer need to allow
untyped calls.
Commit 2 (Fixes Regression - original PR from Matt here: #210)
Walker should check for canonicalized type names
As we know, drgn type equality does not work right, so we need to
compare canonicalized type names. When combined with openzfs/zfs#10236,
zfs_dbgmsgnow works on ztest core dumps.Serapheim Note:
With drgn changing its type rules once again this commit is now needed
for existing tests to not fail.
Commit 3 (Fixes Regression)
update regression output
drgn recently updated its error messages when it comes to page
table lookups to match the latest terminology used by the kernel.
Commit 4 (Fixes Regression; Error-handling improvements with new tests)
ptype: remove anonymous union test and improve error handling
In the past we used to assume lazy type rules from drgn and printing
an anonymous union or struct from its typedef just worked.
Unfortunately, with the latest updates for types in drgn, this no
longer works so part of this commit removes the expectation of
this functionality from our tests. We may want to introduce this
functionality again in the future implemented in a different way.
Fortunately, these kind of types are rare.
The second part of this commit improves the error handling of
looking up types.