Merge pull request #2 from redgeoff/insert-undefined

feat(insert): handle undefined values
delta-db · Dec 12, 2015 · 38c5077 · 38c5077
2 parents c5635c7 + b1304b0
commit 38c5077
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/scripts/common/index.js b/scripts/common/index.js
@@ -42,16 +42,16 @@ SQL.prototype._escapeAndJoin = function (obj, raw) {
     delim = '',
     i = 1;
   utils.each(obj, function (val, key) {
-    // if (typeof val !== 'undefined') { // TODO: remove?
-    keys += delim + self.escape(key);
-    if (raw && raw[key]) {
-      templates += delim + val;
-    } else {
-      templates += delim + self._template(i++);
-      values.push(val);
+    if (typeof val !== 'undefined') {
+      keys += delim + self.escape(key);
+      if (raw && raw[key]) {
+        templates += delim + val;
+      } else {
+        templates += delim + self._template(i++);
+        values.push(val);
+      }
+      delim = ',';
     }
-    delim = ',';
-    // } // TODO: remove?
   });
   return {
     attrs: keys,

diff --git a/test/spec/adapters/common/test-common.js b/test/spec/adapters/common/test-common.js
@@ -139,7 +139,8 @@ Adapter.prototype.test = function () {
             doc_id: '1',
             name: 'thing',
             value: 'write a song',
-            destroyed_at: 'NOW()'
+            destroyed_at: 'NOW()',
+            age: undefined
           },
           'attrs', 'id', ['destroyed_at'])
         .then(function () {