Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): release GIL in the write_deltalake function #2257

Merged

Conversation

franz101
Copy link
Contributor

@franz101 franz101 commented Mar 6, 2024

Description

Release GIL in deltalake.write_deltalake by wrapping it in py.allow_threads

Related Issue(s)

Documentation

@github-actions github-actions bot added the binding/python Issues for the Python package label Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@mrocklin
Copy link

mrocklin commented Mar 7, 2024

Cool! If this works well I suspect that the same pattern would also be useful on other common operations (compact, vacuum, etc..)

@ion-elgreco ion-elgreco force-pushed the feature/release_gil_on_write#2234 branch from fc22aa9 to 0b61692 Compare March 7, 2024 06:06
@ion-elgreco
Copy link
Collaborator

@franz101 you're missing py: Python, as the first variable of the function defintion

@franz101 franz101 changed the title feat(python): Release GIL in deltalake.write_deltalake feat(#2234): release GIL in the write_deltalake function Mar 7, 2024
@franz101
Copy link
Contributor Author

franz101 commented Mar 7, 2024

Cool! If this works well I suspect that the same pattern would also be useful on other common operations (compact, vacuum, etc..)

Essentially all methods here correct?:

  • create
  • delete
  • optimize
  • vacuum
  • ...

@mrocklin
Copy link

mrocklin commented Mar 7, 2024 via email

@ion-elgreco ion-elgreco changed the title feat(#2234): release GIL in the write_deltalake function feat(python): release GIL in the write_deltalake function Mar 7, 2024
@ion-elgreco ion-elgreco force-pushed the feature/release_gil_on_write#2234 branch from 8888594 to d62c17f Compare March 8, 2024 08:39
@ion-elgreco ion-elgreco enabled auto-merge (squash) March 8, 2024 16:35
@ion-elgreco ion-elgreco merged commit 4bcb2e6 into delta-io:main Mar 8, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release GIL in deltalake.write_deltalake
3 participants