fix(python, rust): prevent table scan returning large arrow dtypes #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
fvaleye,
roeap and
rtyler
as code owners
ion-elgreco
force-pushed
the
fix/large_dtype_coercion
branch
from
d5bbdd2
to
ac54d9c
Compare
github-actions
bot
added
binding/python
ion-elgreco
force-pushed
the
fix/large_dtype_coercion
branch
from
ac54d9c
to
07e617c
Compare
ion-elgreco
force-pushed
the
fix/large_dtype_coercion
branch
from
07e617c
to
adf43f0
Compare
Blajda
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Such a small change, but fixes many issues where parquets were written with arrow where the source data was in large dtype format.
By default the parquet::ParquetReader decodes the arrow metadata which in return may give you large dtypes. This would cause issues during DataFusion parquet scan with a filter since the filter wouldn't coerce to the large dtypes. Simply disabling the arrow metadata decoding gives us the parquet schema converted to an arrow schema without large types 👯♂️
Related issue(s)