-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #72 #73
Fixed issue #72 #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
used string formatting instead of concatenation
The build error looks to be unrelated, and might be a similar problem to that which is described in #69 but manifesting through our integration tests.
I'll let @houqp merge this if he's satisfied with the changes. |
#69 is a bug in python binding, while this test is rust only, so it's something else. I will merge this PR for now. Integration test should be fixed in a separate PR. |
Thanks @danielhaviv for the contribution! |
Thanks :) |
we don't have a set release cadence, I was hoping to cut a new release after #75 gets merged. |
No description provided.