Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #72 #73

Merged
merged 6 commits into from
Jan 17, 2021
Merged

Fixed issue #72 #73

merged 6 commits into from
Jan 17, 2021

Conversation

danielhaviv
Copy link
Contributor

No description provided.

@rtyler rtyler added the binding/python Issues for the Python package label Jan 17, 2021
@rtyler rtyler requested a review from houqp January 17, 2021 16:06
Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

python/deltalake/__init__.py Outdated Show resolved Hide resolved
python/deltalake/__init__.py Outdated Show resolved Hide resolved
@houqp houqp mentioned this pull request Jan 17, 2021
used string formatting instead of concatenation
@rtyler
Copy link
Member

rtyler commented Jan 17, 2021

The build error looks to be unrelated, and might be a similar problem to that which is described in #69 but manifesting through our integration tests.

running 2 tests
test s3::test_s3_simple_golden ... ok
test s3::test_s3_simple ... FAILED

failures:

---- s3::test_s3_simple stdout ----
thread 's3::test_s3_simple' panicked at 'dispatch dropped without returning error', /home/tyler/.cargo/registry/src/github.com-1ecc6299db9ec823/hyper-0.13.9/src/client/conn.rs:234:35
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I'll let @houqp merge this if he's satisfied with the changes.

@houqp
Copy link
Member

houqp commented Jan 17, 2021

#69 is a bug in python binding, while this test is rust only, so it's something else. I will merge this PR for now. Integration test should be fixed in a separate PR.

@houqp houqp merged commit 643fd3c into delta-io:main Jan 17, 2021
@houqp
Copy link
Member

houqp commented Jan 17, 2021

Thanks @danielhaviv for the contribution!

@danielhaviv
Copy link
Contributor Author

danielhaviv commented Jan 18, 2021

Thanks :)
What are the release cycles (or when should I expect to see the fix in PyPi)?

@houqp
Copy link
Member

houqp commented Jan 18, 2021

we don't have a set release cadence, I was hoping to cut a new release after #75 gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants