Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken NOTICE link #8

Closed
wants to merge 2 commits into from
Closed

Fix broken NOTICE link #8

wants to merge 2 commits into from

Conversation

wangyum
Copy link
Contributor

@wangyum wangyum commented Apr 25, 2019 •
edited
Loading

It throws No such file or directory when running test in IDEA:
image

The reason is that NOTICE is changed to NOTICE.txt. This PR update the link to NOTICE.txt.

After this PR:
image

@databricks-cla-assistant
Copy link

databricks-cla-assistant commented Apr 25, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@wangyum
Copy link
Contributor Author

wangyum commented Apr 25, 2019

cc @srowen

@srowen
Copy link
Contributor

srowen commented Apr 25, 2019

It's supposed to be there to make sure it's built into the binary artifacts. However it looks like the name of the file at the root was changed to NOTICE.txt before release. Could you just ln -s ../../../NOTICE.txt in that dir and add the symlink to this PR? that will fix it.

@wangyum wangyum changed the title Remove NOTICE link in src/main/resource Fix broken NOTICE link Apr 25, 2019
@mukulmurthy
Copy link
Collaborator

Hi @wangyum , thank you for your help fixing this! We are still setting up our merge processes, but we're working on merging your PR.

@ahirreddy ahirreddy closed this Apr 26, 2019
@ahirreddy ahirreddy reopened this Apr 26, 2019
@brkyvz
Copy link
Collaborator

brkyvz commented Apr 26, 2019

Closing and re-opning to trigger tests

@brkyvz brkyvz closed this Apr 26, 2019
@brkyvz brkyvz reopened this Apr 26, 2019
@ahirreddy ahirreddy closed this in 31ff765 Apr 26, 2019
@mukulmurthy
Copy link
Collaborator

Congrats, @wangyum , for being the first community contributor!

SpaceRangerWes pushed a commit to SpaceRangerWes/delta that referenced this pull request Sep 10, 2019
@wangyum @ahirreddy
[EXTERNAL] Fix broken NOTICE link
d507715 
[EXTERNAL] Fix broken NOTICE link

It throws `No such file or directory` when running test in IDEA:
![image](https://user-images.githubusercontent.com/5399861/56707622-340db600-674c-11e9-9e60-ca706ab8d3a9.png)

The reason is that `NOTICE` is changed to `NOTICE.txt`. This PR update the link to `NOTICE.txt`.

**After this PR**:
![image](https://user-images.githubusercontent.com/5399861/56707853-2c9adc80-674d-11e9-9876-dfc26c56787e.png)

Closes delta-io#8

Author: Yuming Wang <yumwang@ebay.com>

GitOrigin-RevId: af1ec7a0737eba33b3fba44a2be7e6b96c13fc17
LantaoJin added a commit to LantaoJin/delta that referenced this pull request Mar 12, 2021
@LantaoJin
[CARMEL-4005] Use collectAsIterator() instead of toLocalIterator() to…
eab3180 
… minimize number of job launching (delta-io#8)
jbguerraz pushed a commit to jbguerraz/delta that referenced this pull request Jul 6, 2022
@JassAbidi
Merge pull request delta-io#8 from delta-io/master
7041c1a 
update fork
tdas pushed a commit to tdas/delta that referenced this pull request May 31, 2023
@windpiger @zsxwing
minor modify README.md (delta-io#8)
e932a92
andreaschat-db added a commit to andreaschat-db/delta that referenced this pull request Apr 23, 2024
@andreaschat-db
# This is a combination of 12 commits.
ea7b635 
# This is the 1st commit message:

flush

# This is the commit message delta-io#2:

flush

# This is the commit message delta-io#3:

First sane version without isRowDeleted

# This is the commit message delta-io#4:

Hack RowIndexMarkingFilters

# This is the commit message delta-io#5:

Add support for non-vectorized readers

# This is the commit message delta-io#6:

Metadata column fix

# This is the commit message delta-io#7:

Avoid non-deterministic UDF to filter deleted rows

# This is the commit message delta-io#8:

metadata with Expression ID

# This is the commit message delta-io#9:

Fix complex views issue

# This is the commit message delta-io#10:

Tests

# This is the commit message delta-io#11:

cleaning

# This is the commit message delta-io#12:

More tests and fixes
andreaschat-db added a commit to andreaschat-db/delta that referenced this pull request Apr 23, 2024
@andreaschat-db
# This is a combination of 16 commits.
ad044ef 
# This is the 1st commit message:

flush

# This is the commit message delta-io#2:

flush

# This is the commit message delta-io#3:

First sane version without isRowDeleted

# This is the commit message delta-io#4:

Hack RowIndexMarkingFilters

# This is the commit message delta-io#5:

Add support for non-vectorized readers

# This is the commit message delta-io#6:

Metadata column fix

# This is the commit message delta-io#7:

Avoid non-deterministic UDF to filter deleted rows

# This is the commit message delta-io#8:

metadata with Expression ID

# This is the commit message delta-io#9:

Fix complex views issue

# This is the commit message delta-io#10:

Tests

# This is the commit message delta-io#11:

cleaning

# This is the commit message delta-io#12:

More tests and fixes

# This is the commit message delta-io#13:

Partial cleaning

# This is the commit message delta-io#14:

cleaning and improvements

# This is the commit message delta-io#15:

cleaning and improvements

# This is the commit message delta-io#16:

Clean RowIndexFilter
andreaschat-db added a commit to andreaschat-db/delta that referenced this pull request Apr 26, 2024
@andreaschat-db
# This is a combination of 12 commits.
40b0238 
# This is the 1st commit message:

flush

# This is the commit message delta-io#2:

flush

# This is the commit message delta-io#3:

First sane version without isRowDeleted

# This is the commit message delta-io#4:

Hack RowIndexMarkingFilters

# This is the commit message delta-io#5:

Add support for non-vectorized readers

# This is the commit message delta-io#6:

Metadata column fix

# This is the commit message delta-io#7:

Avoid non-deterministic UDF to filter deleted rows

# This is the commit message delta-io#8:

metadata with Expression ID

# This is the commit message delta-io#9:

Fix complex views issue

# This is the commit message delta-io#10:

Tests

# This is the commit message delta-io#11:

cleaning

# This is the commit message delta-io#12:

More tests and fixes
andreaschat-db added a commit to andreaschat-db/delta that referenced this pull request Apr 26, 2024
@andreaschat-db
# This is a combination of 16 commits.
0826e53 
# This is the 1st commit message:

flush

# This is the commit message delta-io#2:

flush

# This is the commit message delta-io#3:

First sane version without isRowDeleted

# This is the commit message delta-io#4:

Hack RowIndexMarkingFilters

# This is the commit message delta-io#5:

Add support for non-vectorized readers

# This is the commit message delta-io#6:

Metadata column fix

# This is the commit message delta-io#7:

Avoid non-deterministic UDF to filter deleted rows

# This is the commit message delta-io#8:

metadata with Expression ID

# This is the commit message delta-io#9:

Fix complex views issue

# This is the commit message delta-io#10:

Tests

# This is the commit message delta-io#11:

cleaning

# This is the commit message delta-io#12:

More tests and fixes

# This is the commit message delta-io#13:

Partial cleaning

# This is the commit message delta-io#14:

cleaning and improvements

# This is the commit message delta-io#15:

cleaning and improvements

# This is the commit message delta-io#16:

Clean RowIndexFilter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

@mukulmurthy mukulmurthy mukulmurthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wangyum @databricks-cla-assistant @srowen @mukulmurthy @brkyvz @ahirreddy