Run loop refactor and starting offsets feature #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2021
Closed
mosyp
reviewed
Oct 18, 2021
mosyp
approved these changes
Oct 19, 2021
mosyp
reviewed
Oct 19, 2021
* Add rustdocs for behavior when starting offsets reference invalid Kafka offsets * Log topic instead of table uri (except for checkpoints) to shorten the log message weight * Lengthen wait_for_version_created timeout to 3 minutes and panic instead of returning * Add token.cancel back to emails_s3_tests
xianwill
commented
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the run loop structure and adds support for specifying explicit starting offsets.
Apologies, there is a lot to look at here, but it needed to be done. The lions share of changes are in
lib.rs.The main changes include:
start_ingest) instead of a struct method and we now execute the run loop directly within it.ProcessingStateandIngestProcessorinto justIngestProcessor.Arc<Mutex<PartitionAssignment>>, we now have anArc<RwLock<Option<RebalanceSignal>>>for responding to rebalance events so we no longer have to hold a lock while updating the PartitionAssignment.In the near future, I think we may look at breaking some files out of
lib.rsfor another cleanup pass.