🎨 Update code to google format #2
Conversation
Resolves: #1
| /** | ||
| * Stops the GamePadManager (stops the SDL thread in the native lib). | ||
| * | ||
| * Note: waits for the the SDL thread to finish. |
| * | ||
| * Note: waits for the the SDL thread to finish. | ||
| * | ||
| * @return True if stopped, false if not. |
There was a problem hiding this comment.
Description could be clearer. E.g. true if successfully stopped. Now it reads as if it is possible it will keep running or smth
There was a problem hiding this comment.
Also @code should be used here. I'll create an issue.
|
It's an okay start but since a refactor is necessary I don't see the added value in this PR |
|
One thing at a time. |
Codacy remarked two issues: * Unscoped field `gamePadManager` which could also have been local * Empty method body `Main#onGamePadError(String error)`
RyanMeulenkamp
force-pushed
the
ryan/fix-code-format
branch
from
cf19118
to
3932577
Compare
|
|
||
| /// Value of the enumeration. | ||
| private final int value; | ||
| /// Value of the enumeration. |
There was a problem hiding this comment.
these type of comments don't conform to the google style
| * | ||
| * @param value The value of the controller axis. | ||
| */ | ||
| GamePadAxis(int value) { |
There was a problem hiding this comment.
i'm guessing these should be explicitly public
There was a problem hiding this comment.
now it's package private right?
There was a problem hiding this comment.
You guys know this is the only possible scope (implicitly private) for enum constructors in java?
Touches: #4
RyanMeulenkamp
force-pushed
the
ryan/fix-code-format
branch
from
692c52d
to
da06205
Compare
Resolves: #3
RyanMeulenkamp
force-pushed
the
ryan/fix-code-format
branch
from
da06205
to
e0ea718
Compare
Resolves: #5
Resolves: #1