-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/publish rework #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzkirstein
added
Status: Do Not Merge
Not yet ready to be merged
Type: Enhancement
Feature enhancement request
labels
Aug 10, 2023
Abrom8
requested changes
Aug 15, 2023
moritzkirstein
force-pushed
the
feat/publish-rework
branch
from
August 16, 2023 10:26
5d3cb19
to
9e41ac9
Compare
moritzkirstein
temporarily deployed
to
github-pages
August 17, 2023 10:18
— with
GitHub Actions
Inactive
moritzkirstein
temporarily deployed
to
github-pages
August 17, 2023 11:16
— with
GitHub Actions
Inactive
Abrom8
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a complete overhaul to the asset publishing process.
Implements #29
Implements #32
Implements #30
Fixes #40
Proposed Changes
NautilusDDO
wrapper classNautilusService
andNautilusAsset
classes respectivelyNautilusDDO
andNautilusService
Additional Information
Ignore
/docs/*
for review, as these are automatically generated on release. Documentation needs to be updated before 0.3.0 release.Some tests need to be re-enabled before release.