Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/publish rework #46

Merged
merged 67 commits into from
Aug 18, 2023
Merged

Feat/publish rework #46

merged 67 commits into from
Aug 18, 2023

Conversation

moritzkirstein
Copy link
Contributor

@moritzkirstein moritzkirstein commented Aug 10, 2023

Introduces a complete overhaul to the asset publishing process.

Implements #29
Implements #32
Implements #30
Fixes #40

Proposed Changes

  • Introduce NautilusDDO wrapper class
  • Update NautilusService and NautilusAsset classes respectively
  • Rework the publishing flow, using a multi-step approach to
    1. Create a NFT asset
    2. Create Datatokens and Pricings for all Services of the offering
    3. Create a valid DDO with previous tsx
    4. Publish the DDO on the NFT asset
  • Introduce and improve unit tests for NautilusDDO and NautilusService

Additional Information

Ignore /docs/* for review, as these are automatically generated on release. Documentation needs to be updated before 0.3.0 release.
Some tests need to be re-enabled before release.

@moritzkirstein moritzkirstein added Status: Do Not Merge Not yet ready to be merged Type: Enhancement Feature enhancement request labels Aug 10, 2023
src/Nautilus/Asset/NautilusDDO.ts Outdated Show resolved Hide resolved
src/Nautilus/Asset/NautilusDDO.ts Outdated Show resolved Hide resolved
test/unit/NautilusDDO.test.ts Outdated Show resolved Hide resolved
test/unit/NautilusDDO.test.ts Outdated Show resolved Hide resolved
src/Nautilus/Asset/NautilusDDO.ts Outdated Show resolved Hide resolved
src/Nautilus/Asset/Service/NautilusService.ts Outdated Show resolved Hide resolved
src/Nautilus/Nautilus.ts Outdated Show resolved Hide resolved
src/@types/Publish.ts Outdated Show resolved Hide resolved
src/publish/index.ts Show resolved Hide resolved
src/publish/index.ts Show resolved Hide resolved
@moritzkirstein moritzkirstein removed the Status: Do Not Merge Not yet ready to be merged label Aug 17, 2023
@moritzkirstein moritzkirstein temporarily deployed to github-pages August 17, 2023 10:18 — with GitHub Actions Inactive
@moritzkirstein moritzkirstein temporarily deployed to github-pages August 17, 2023 11:16 — with GitHub Actions Inactive
@moritzkirstein moritzkirstein merged commit 8af93a8 into main Aug 18, 2023
3 checks passed
@moritzkirstein moritzkirstein deleted the feat/publish-rework branch August 18, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Feature enhancement request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] setDatatokenNameAndSymbol should be part of the service builder
2 participants