Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorful background #22

Closed
wants to merge 1 commit into from
Closed

colorful background #22

wants to merge 1 commit into from

Conversation

lefherz
Copy link
Contributor

@lefherz lefherz commented Feb 25, 2020

So, this should be enough to closes #2 :) Hope you like it.

@lefherz
Copy link
Contributor Author

lefherz commented Feb 25, 2020

The preview is here: https://staging.bots.delta.chat/22/

Unfortunately at https://staging.bots.delta.chat/22/contact.html the white box is longer than expected. I didn't find out why yet, does anyone have a hint? Anyway, it's not a blocker imo.

Note that the preview doesn't work in my chromium, I think because chromium cashed my referer as staging.bots.delta.chat/19/ o.0 anyway, it's pulling the css from a wrong URL and gets a 404. If you have the same problem, open the page in an anonymous window or in firefox, then it works. 🤦‍♀️

@lefherz lefherz requested a review from pabzm February 25, 2020 13:02
@pabzm
Copy link
Contributor

pabzm commented Feb 25, 2020

Um, I'm not a fan of color gradients, to be honest.

Me asking for more colours was rather targeting text-and logo-colors, together with a general overhaul of font-selection, layout proportions, etc. Not being more colourful for the sake of it.

Sorry I wasn't clearer before!

Can we somehow put this aside until someone tackles the overall aesthetics of the pages?

@lefherz
Copy link
Contributor Author

lefherz commented Feb 26, 2020

Yes, we can put that aside :D aesthetics are hard.

@lefherz lefherz closed this Feb 26, 2020
@pabzm
Copy link
Contributor

pabzm commented Feb 26, 2020

Thanks for understanding! :)

@lefherz lefherz mentioned this pull request Mar 2, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beautify pages
2 participants