Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Make frontend pure binary crate #33

Closed
wants to merge 17 commits into from
Closed

Conversation

Septias
Copy link
Collaborator

@Septias Septias commented Sep 16, 2021

On startup, cargo complains about colliding names of the binary and library crate from dc40-frontend.
As #6313 from cargo-crate gh says this is #6308 a check if multiple jobs produce the same files so dc40 gets compiled twice which increases load times.
By making dc40-frontend a pure binary crate this problem is solved.

The bin target `dc40-frontend` in package `dc40-frontend v0.1.0 (/home/septias/programming/dc40/frontend)` has the same output filename as the lib target `dc40-frontend` in package `dc40-frontend v0.1.0 (/home/septias/programming/dc40/frontend)`.
Colliding filename is: /home/septias/programming/dc40/frontend/target/wasm32-unknown-unknown/debug/deps/dc40_frontend.wasm
The targets should have unique names.
Consider changing their names to be unique or compiling them separately.
This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.

@Simon-Laux
Copy link
Member

please rebase this onto master and do a force push, there are like 16 unrelated commits in this pr

Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase needed

@Septias Septias closed this Sep 30, 2022
@Septias
Copy link
Collaborator Author

Septias commented Sep 30, 2022

has some unneccessary changes. We can make a clean one if needed

@Simon-Laux Simon-Laux deleted the make_frontend_pure_bin branch September 30, 2022 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants