-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compile time dependency on GMS #2361
Comments
cc @adbenitez @Hocuri @missytake I suggest that we
Assign the issue to self if you are going to do it. Then keep this issue until the fix is upstreamed to MapLibre so we don't have to maintain a fork. |
There is a https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11532 that already works for me. |
Upstream report: maplibre/maplibre-native#379 |
maplibre 10 is out for a while now, plans to update? |
I have tried to make an update at #2542, but MapLibre 10 breaks Android 4 support. Filed an upstream bugreport at maplibre/maplibre-native#1010 |
since MapLibre 10 breaks support for Android 4 and it seems they can't bring it back lower than API level 18 anyway because their needs, so this issue can be closed also because meanwhile the issue is solved by fdroid somehow, any advancements in this area will be with the complete removal of MapLibre, not upgrading it, the path to follow will probably be similar to what DC iOS is planning: https://github.com/deltachat/deltachat-ios/pull/1912 |
Follow-up to #2349, runtime dependency and non-free components are removed, but GMS is still downloaded during the build.
See https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11527#note_1053804549
A quick solution to get DeltaChat to F-Droid is to use a patched version of mapbox-events-android, like here:
ev-map/EVMap@ed80d7b
Patched version is at https://github.com/johan12345/mapbox-events-android
Proper solution is to upstream fixes to MapLibre and introduce a free build flavour, suggested at https://gitlab.com/fdroid/fdroiddata/-/merge_requests/11527#note_1053885392
The text was updated successfully, but these errors were encountered: