-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude com.google.android.gms from apk binaries #2303
Conversation
To test the changes in this pull request, install this apk: |
Confirmed this cleans up 👍 |
@adbenitez right, 626 needs to be disabled too, 621 does not have these classes in ref: https://gitlab.com/fdroid/fdroiddata/-/commit/55751671beaac41b9543a9ad9b03082874f7c775 |
@licaon-kter i yesterday tagged 1.30.2 (631), that includes this pr and should hopefully work out :) f-droid picked the tag already up, https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/com.b44t.messenger.yml , so it is probably in the build queue again - can you say how long f-droid builds take these days until available in the f-droid app? |
@r10s current cycle has ended and awaits publishing, so this will be in the next one: https://monitor.f-droid.org/builds/running |
@licaon-kter thanks a lot for these information in special and for your work on f-droid in general <3 |
recently DeltaLab got added to IzzyOnDroid repo and after being scanned with some apk analyzer got marked with anti-features because GMS blobs are bundled in the apk due to maplibre including it, this is also happening in official Delta Chat.
I excluded gms and all seems to work fine because in practice we don't use google services, and reading maplibre's repo, the class using the
gms
package iscom.mapbox.mapboxsdk.location.engine.GoogleLocationEngineImpl
and in:https://github.com/maplibre/maplibre-gl-native/blob/ea234edf67bb3aec75f077e15c1c30c99756b926/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationComponent.java#L83
it says that for
GoogleLocationEngineImpl
to be used:since we don't add it, it is unused, but yet the
com.google.android.gms
was bundled in the apkWithout this Delta Chat might get flagged on f-droid (other apps are getting similar issues, check https://gitlab.com/fdroid/fdroiddata/-/merge_requests/10991 )
as a plus this should make the apk size a bit smaller :)