Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude com.google.android.gms from apk binaries #2303

Merged
merged 1 commit into from
May 20, 2022
Merged

Conversation

adbenitez
Copy link
Member

recently DeltaLab got added to IzzyOnDroid repo and after being scanned with some apk analyzer got marked with anti-features because GMS blobs are bundled in the apk due to maplibre including it, this is also happening in official Delta Chat.

I excluded gms and all seems to work fine because in practice we don't use google services, and reading maplibre's repo, the class using the gms package is com.mapbox.mapboxsdk.location.engine.GoogleLocationEngineImpl and in:
https://github.com/maplibre/maplibre-gl-native/blob/ea234edf67bb3aec75f077e15c1c30c99756b926/platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationComponent.java#L83
it says that for GoogleLocationEngineImpl to be used:

simply add the Google Play Location Services dependency in your build script.

since we don't add it, it is unused, but yet the com.google.android.gms was bundled in the apk

Without this Delta Chat might get flagged on f-droid (other apps are getting similar issues, check https://gitlab.com/fdroid/fdroiddata/-/merge_requests/10991 )

as a plus this should make the apk size a bit smaller :)

@adbenitez adbenitez requested review from r10s and Hocuri May 18, 2022 03:56
@github-actions
Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez merged commit 90c61fd into master May 20, 2022
@adbenitez adbenitez deleted the adb/exclude-gms branch May 20, 2022 09:56
@licaon-kter
Copy link

Confirmed this cleans up 👍

@r10s r10s mentioned this pull request May 24, 2022
@licaon-kter
Copy link

@adbenitez right, 626 needs to be disabled too, 621 does not have these classes in smali/, this happens when one mixes 2 tasks at once :(

ref: https://gitlab.com/fdroid/fdroiddata/-/commit/55751671beaac41b9543a9ad9b03082874f7c775

@r10s
Copy link
Member

r10s commented May 25, 2022

@licaon-kter i yesterday tagged 1.30.2 (631), that includes this pr and should hopefully work out :)

f-droid picked the tag already up, https://gitlab.com/fdroid/fdroiddata/blob/master/metadata/com.b44t.messenger.yml , so it is probably in the build queue again - can you say how long f-droid builds take these days until available in the f-droid app?

@licaon-kter
Copy link

licaon-kter commented May 25, 2022

@r10s
Copy link
Member

r10s commented May 25, 2022

@licaon-kter thanks a lot for these information in special and for your work on f-droid in general <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants