consolidate wording for "Message Info" #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, "Info" and "Message Details" were used for the same things synonymously, this is an issue mostly in the context menus, where eg. iOS had "Info" but desktop did not - and android had an "i"-icon ... but also, tapping 'Info' and then getting a different title (not only a longer version) is not super-nice. with this change, everything is "Info", making also the "i"-icon fit. this is also consistent with WhatsApp. Signal has the same mess as we before, at least on iOS.
adbenitez
approved these changes
Jun 19, 2024
r10s
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jun 19, 2024
gist is to use an easier, less cluttering language - before, we had context menu items named 'Info', 'Message Details' or just 'i', opening then 'Message Details'. together with deltachat/deltachat-android#3137 , the menu entry will be named 'Info' everywhere and open a 'Message Info' dialog, this has the following benefits: - inner consistency to other Delta Chat apps all apps have recognizable 'Info' in their context menu, opening a 'Message Info' dialog - inner consistency to other desktopn menu entries: 'Message Details' is a little too much as the context 'Message' is already clear. (we also do not say 'Forward Message' or 'Reply to Message'; as an exception, we regard only 'Delete Message'). - also, 'Info' is shorter and fits better to the otherwise short menu titles. - outer consistency: 'Info' is very well known for that kind of, well, info
r10s
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jun 19, 2024
gist is to use an easier, less cluttering language - before, we had context menu items named 'Info', 'Message Details' or just 'i', opening then 'Message Details'. together with deltachat/deltachat-android#3137 , the menu entry will be named 'Info' everywhere and open a 'Message Info' dialog, this has the following benefits: - inner consistency to other Delta Chat apps all apps have recognizable 'Info' in their context menu, opening a 'Message Info' dialog - inner consistency to other desktopn menu entries: 'Message Details' is a little too much as the context 'Message' is already clear. (we also do not say 'Forward Message' or 'Reply to Message'; as an exception, we regard only 'Delete Message'). - also, 'Info' is shorter and fits better to the otherwise short menu titles. - outer consistency: 'Info' is very well known for that kind of, well, info
Simon-Laux
pushed a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Jun 19, 2024
* consolidate wording for "Message Info" gist is to use an easier, less cluttering language - before, we had context menu items named 'Info', 'Message Details' or just 'i', opening then 'Message Details'. together with deltachat/deltachat-android#3137 , the menu entry will be named 'Info' everywhere and open a 'Message Info' dialog, this has the following benefits: - inner consistency to other Delta Chat apps all apps have recognizable 'Info' in their context menu, opening a 'Message Info' dialog - inner consistency to other desktopn menu entries: 'Message Details' is a little too much as the context 'Message' is already clear. (we also do not say 'Forward Message' or 'Reply to Message'; as an exception, we regard only 'Delete Message'). - also, 'Info' is shorter and fits better to the otherwise short menu titles. - outer consistency: 'Info' is very well known for that kind of, well, info * add CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before, "Info" and "Message Details" were used for the same things synonymously,
this is an issue mostly in the context menus,
where eg. iOS had "Info" but desktop did not -
and android had an "i"-icon ...
but also, tapping 'Info' and then getting a different title (not only a longer version) is not super-nice.
with this change, everything is "Info", making also the "i"-icon fit. this is also consistent with WhatsApp.
Signal has the same mess as we before, at least on iOS.
once this is merged,
./scripts/tx-update-changed-sources.shneeds to be run