remove deprecated hint 'chat with any email' #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the string is deprecated and also no longer used on desktop/iOS. the 'empty state view' where the string could appear is anyways not shown often (usually, there is 'saved messages' and 'device messages'), so it also does not make sense to think over a replacement.
|
To test the changes in this pull request, install this apk: |
adbenitez
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the string is deprecated and also no longer used on desktop/iOS.
the 'empty state view' where the string could appear is anyways not shown often
(usually, there is 'saved messages' and 'device messages'), so it also does not make sense to think over a replacement.
the string as such can be removed in a subsequent PR when we cleanup unused strings.