Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encrypted messages with attachments don't have protected-headers="v1" in the header #2302

Closed
link2xt opened this issue Mar 19, 2021 · 2 comments
Closed

Encrypted messages with attachments don't have protected-headers="v1" in the header #2302

link2xt opened this issue Mar 19, 2021 · 2 comments
Assignees
@iequidoo
Labels
bug Something is not working good first issue Good for newcomers

Comments

@link2xt
Copy link
Collaborator

link2xt commented Mar 19, 2021

This line does not work for multipart/mixed parts:

deltachat-core-rust/src/mimefactory.rs

Line 591 in 36aef64

let message = message.replace_header(Header::new(

The result is still Content-Type: multipart/mixed; boundary="some-random-string", so Thunderbird does not look for protected headers and displays message Subject as ....
@link2xt link2xt added the bug Something is not working label Mar 19, 2021
@link2xt
Copy link
Collaborator Author

link2xt commented Mar 19, 2021

The source of the problem is here:
https://github.com/deltachat/rust-email/blob/25702df99254d059483b41417cd80696a258df8e/src/message.rs#L189

@link2xt link2xt added the good first issue Good for newcomers label Jul 25, 2023
@link2xt
Copy link
Collaborator Author

link2xt commented Jul 25, 2023

Marking it as a good first issue because it is clear what the result should be, but I am not sure it is actually easy to implement.

@link2xt link2xt mentioned this issue Sep 30, 2023
Merged
@iequidoo iequidoo self-assigned this Oct 1, 2023
@iequidoo iequidoo mentioned this issue Oct 2, 2023
Merged
iequidoo added a commit that referenced this issue Oct 2, 2023
@iequidoo
fix: Add protected-headers directive to Content-Type of encrypted/sig…
6345099 
…ned MIME (#2302)

Add protected-headers="v1" directive to Content-Type of an encrypted/signed MIME so that other MUAs
like Thunderbird display the true message Subject instead of "...".
@iequidoo iequidoo mentioned this issue Oct 2, 2023
Merged
iequidoo added a commit that referenced this issue Oct 3, 2023
@iequidoo
fix: Add protected-headers directive to Content-Type of encrypted/sig…
bbd96c4 
…ned MIME (#2302)

Add protected-headers="v1" directive to Content-Type of an encrypted/signed MIME so that other MUAs
like Thunderbird display the true message Subject instead of "...".
link2xt pushed a commit that referenced this issue Oct 4, 2023
@iequidoo @link2xt
fix: Add protected-headers directive to Content-Type of encrypted/sig…
b30faed 
…ned MIME (#2302)

Add protected-headers="v1" directive to Content-Type of an encrypted/signed MIME so that other MUAs
like Thunderbird display the true message Subject instead of "...".
link2xt pushed a commit that referenced this issue Oct 4, 2023
@iequidoo @link2xt
fix: Add protected-headers directive to Content-Type of encrypted/sig…
5aa0205 
…ned MIME (#2302)

Add protected-headers="v1" directive to Content-Type of an encrypted/signed MIME so that other MUAs
like Thunderbird display the true message Subject instead of "...".
@link2xt link2xt closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iequidoo iequidoo

Labels
bug Something is not working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@link2xt @iequidoo