Use new mailparse API to parse Message-IDs #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
mailparse-msgids
branch
3 times, most recently
from
c81337a
to
ecda36f
Compare
hpk42
reviewed
Feb 22, 2020
| if ids.len() == 1 { | ||
| let id = &ids[0]; | ||
| if id.starts_with('<') && id.ends_with('>') { | ||
| Ok(id.chars().skip(1).take(id.len() - 2).collect()) |
There was a problem hiding this comment.
looks a bit complicated -- i take it that something like id[1..id.len()-1].clone() or so does not work?
There was a problem hiding this comment.
Indexing operates on byte level, it is unsafe.
This was referenced Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message-IDs are not addresses, and should be parsed differently.