-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limit rate of webxdc updates #3417
Conversation
ae8e6a9
to
c0a17df
Compare
fe87f76
to
66e59b2
Compare
aae4787
to
825ceba
Compare
804b638
to
75ff886
Compare
@link2xt thanks a lot for the detailed review, i incorporated lots of your ideas. especially the sql-part is much easier now :) for the ratelimit in i think the risk in adding new issues there is much larger than the effect - most times, there is only one status-update/sync anyway - and even if there are multiple, it is better than before in all cases. so, to me, it seems that the current approach in |
bb99324
to
77eae92
Compare
this avoids starting several tasks and allows sending updates out after a restart of the app.
… messages are actually sent out
this pr is based based on the ratelimited introduced by #3402:
instead of sending the status-update-message directly, we now just interrupt smtp; the real status-update-message is then created in the smtp-loop (similar to sync-messages and mdn) and interrupting smtp.
ratelimit is then handled in the same, already implemented way, resulting in smtp being interrupted again if there is another chance that something can be sent.
as a nice side-effect, also sync-messages are delayed as well when ratelimit happens.
closes #3311