Verified 1:1 chats in Core #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hocuri
force-pushed
the
verified-oneonone
branch
2 times, most recently
from
4c1a85a
to
b0998af
Compare
Hocuri
force-pushed
the
verified-oneonone
branch
from
3fd0be3
to
3d89059
Compare
5 tasks
Hocuri
force-pushed
the
verified-oneonone
branch
3 times, most recently
from
c76f85c
to
726a0af
Compare
Hocuri
force-pushed
the
verified-oneonone
branch
from
bd799a7
to
99f6b84
Compare
Hocuri
commented
Jun 22, 2023
Hocuri
commented
Jun 22, 2023
|
a feature flat which needs to be set by UIs that support it sounds
like the best option to me. With this, non-supporting UIs will
show 1:1 chats without verification-tick and state-change-notifications
and also not drop to "contact request" mode on broken key setup, right?
…On Thu, Jun 22, 2023 at 11:12 -0700, Hocuri wrote:
@Hocuri commented on this pull request.
> + } else if self.is_protection_broken() {
+ Some(ProtectionBroken)
Hm, I just noticed that returning `false` here means that until the UIs adapt to this change, when a verification is broken, the user won't be able to send to the chat, and have no way to fix this.
Opinions on how to solve this are welcome.
Options:
- Require that all the UIs to at least treat `is_protection_broken()` like `is_contact_request()` before the next release. Disadvantage: Coordinating with all UIs is a lot of effort.
- Let `can_send()` return `true` for now, and wait until all the UIs adapt, and then introduce this change. Disadvantage: Buttons like "Video Chat" will still be shown (and work) when a chat protection is broken, even though the user is not supposed to be able to send anything before accepting.
- Let the UIs set a feature flag to enable verified 1:1 chats.
--
Reply to this email directly or view it on GitHub:
#4315 (review)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
link2xt
reviewed
Jun 30, 2023
link2xt
reviewed
Jul 4, 2023
link2xt
reviewed
Jul 4, 2023
link2xt
approved these changes
Jul 4, 2023
…chat protection should be upgraded/downgraded
Co-authored-by: link2xt <link2xt@testrun.org>
Co-authored-by: link2xt <link2xt@testrun.org>
Hocuri
commented
Jul 8, 2023
|
Hooray! Looking forward to see this in action. Thanks Hocuri for persevering through all the work!
…On Sun, Jul 09, 2023 at 05:06 -0700, Hocuri wrote:
Merged #4315 into master.
--
Reply to this email directly or view it on GitHub:
#4315 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
This was referenced Jul 11, 2023
Hocuri
added a commit
to deltachat/deltachat-android
that referenced
this pull request
Jul 14, 2023
Depends on deltachat/deltachat-core-rust#4315. Follow-up for #2541. - Show a "verified" icon on protection changed update messages - Add C API - Show a dialog over the input bar not only for contact requests, but also when the protection is broken (using the new method `isHalfBlocked()`) - The positive button reads "OK" (as opposed to contact requests where it reads "Accept") - Add SVG icons, remove PNG one - Translations - When tapping on the `DC_INFO_PROTECTION_{EN|DIS}ABLED` message, show more information (for now, it leads to the online preview of my FAQ PR) - Block loading remote images in the "Full Msg View" not only for contact requests, also when the protection is broken (using the new method `isHalfBlocked()`) - Show a big verified/crossed-out-verified symbol over the `DC_INFO_PROTECTION_{EN|DIS}ABLED` messages - Fix a bug that was kind of present before (for contact requests) but only became really visible now: - Set a draft with an image (or other attachment) - Your chat partner breaks verification - Expected: Both the input bar and the draft image are hidden by the input-bar-dialog. - Bug behavior (before c31de5b): The input bar is hidden, but the draft image stays visible.
Septias
added a commit
that referenced
this pull request
Oct 13, 2023
Implement #4188 BREAKING CHANGE: Remove unused DC_STR_PROTECTION_(EN)ABLED* strings BREAKING CHANGE: Remove unused dc_set_chat_protection()
Hocuri
added a commit
to deltachat/deltachat-android
that referenced
this pull request
Oct 23, 2023
Depends on deltachat/deltachat-core-rust#4315. Follow-up for #2541. - Show a "verified" icon on protection changed update messages - Add C API - Show a dialog over the input bar not only for contact requests, but also when the protection is broken (using the new method `isHalfBlocked()`) - The positive button reads "OK" (as opposed to contact requests where it reads "Accept") - Add SVG icons, remove PNG one - Translations - When tapping on the `DC_INFO_PROTECTION_{EN|DIS}ABLED` message, show more information (for now, it leads to the online preview of my FAQ PR) - Block loading remote images in the "Full Msg View" not only for contact requests, also when the protection is broken (using the new method `isHalfBlocked()`) - Show a big verified/crossed-out-verified symbol over the `DC_INFO_PROTECTION_{EN|DIS}ABLED` messages - Fix a bug that was kind of present before (for contact requests) but only became really visible now: - Set a draft with an image (or other attachment) - Your chat partner breaks verification - Expected: Both the input bar and the draft image are hidden by the input-bar-dialog. - Bug behavior (before c31de5b): The input bar is hidden, but the draft image stays visible.
Merged
r10s
pushed a commit
to deltachat/deltachat-android
that referenced
this pull request
Oct 26, 2023
Depends on deltachat/deltachat-core-rust#4315. Follow-up for #2541. - Show a "verified" icon on protection changed update messages - Add C API - Show a dialog over the input bar not only for contact requests, but also when the protection is broken (using the new method `isHalfBlocked()`) - The positive button reads "OK" (as opposed to contact requests where it reads "Accept") - Add SVG icons, remove PNG one - Translations - When tapping on the `DC_INFO_PROTECTION_{EN|DIS}ABLED` message, show more information (for now, it leads to the online preview of my FAQ PR) - Block loading remote images in the "Full Msg View" not only for contact requests, also when the protection is broken (using the new method `isHalfBlocked()`) - Show a big verified/crossed-out-verified symbol over the `DC_INFO_PROTECTION_{EN|DIS}ABLED` messages - Fix a bug that was kind of present before (for contact requests) but only became really visible now: - Set a draft with an image (or other attachment) - Your chat partner breaks verification - Expected: Both the input bar and the draft image are hidden by the input-bar-dialog. - Bug behavior (before c31de5b): The input bar is hidden, but the draft image stays visible.
r10s
added a commit
to deltachat/deltachat-android
that referenced
this pull request
Oct 27, 2023
* Verified 1:1 chats, Android UI (#2560) Depends on deltachat/deltachat-core-rust#4315. Follow-up for #2541. - Show a "verified" icon on protection changed update messages - Add C API - Show a dialog over the input bar not only for contact requests, but also when the protection is broken (using the new method `isHalfBlocked()`) - The positive button reads "OK" (as opposed to contact requests where it reads "Accept") - Add SVG icons, remove PNG one - Translations - When tapping on the `DC_INFO_PROTECTION_{EN|DIS}ABLED` message, show more information (for now, it leads to the online preview of my FAQ PR) - Block loading remote images in the "Full Msg View" not only for contact requests, also when the protection is broken (using the new method `isHalfBlocked()`) - Show a big verified/crossed-out-verified symbol over the `DC_INFO_PROTECTION_{EN|DIS}ABLED` messages - Fix a bug that was kind of present before (for contact requests) but only became really visible now: - Set a draft with an image (or other attachment) - Your chat partner breaks verification - Expected: Both the input bar and the draft image are hidden by the input-bar-dialog. - Bug behavior (before c31de5b): The input bar is hidden, but the draft image stays visible. * change button order of verification-broken alert (#2621) Having "OK" in the middle of the buttons is weird. The old order was: ``` End-to-end encryption cannot... [More Info] [OK] [Scan QR code] ``` 1. _If_ the main purpose of the dialog would be to "Scan QR code", the text should point that out more, also the opening button. Then, the button position would be correct, however, it has to read "Cancel" then. 2. _However_, the main purpose of the dialog is to "Show Info", "Scan QR code" is only an optional offering and the button a shortcut only. And finishing "Show Info" is better done by a simple "OK". Then, the "OK" should be rightmost. This PR implements the second option, the buttons read as follows afterwards: ``` End-to-end encryption cannot... [More Info] [Scan QR code] [OK] ``` * fix: load updated display name when chat protection breaks * Implement feature flag for verified 1:1 chats * Update res/values/strings.xml Co-authored-by: Hocuri <hocuri@gmx.de> * Update src/org/thoughtcrime/securesms/connect/DcHelper.java * Make another AlertDialog * Revert "Implement feature flag for verified 1:1 chats" This reverts commit 2efd17e. * Fix typo * email server->email provider --------- Co-authored-by: bjoern <r10s@b44t.com> Co-authored-by: adbenitez <asieldbenitez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #4188
BREAKING CHANGE: Remove unused
DC_STR_PROTECTION_(EN)ABLED*stringsBREAKING CHANGE: Remove unused
dc_set_chat_protection()TODO before merging: Discuss about whether the outstanding Concerns and Unresolved Questions at #4188 should block merging.
TODO after merging: