fix(node): undefine NAPI_EXPERIMENTAL #5489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes build with new clang which treats -Wincompatible-function-pointer-types as an error. Related upstream issue: <nodejs/node#52229>
link2xt
force-pushed
the
link2xt/node-no-experimental
branch
from
d17d36d
to
848959e
Compare
|
I have tested in #5488 and confirmed that problem is not Node version, but updated clang. Problem happens even with node 18. This PR fixes desktop issue deltachat/deltachat-desktop#3783 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build with new clang
which treats -Wincompatible-function-pointer-types as an error.
Related upstream issue: nodejs/node#52229