fix: do not require the Message to render MDN #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
link2xt/mdn-no-message
branch
4 times, most recently
from
90aa446
to
e136f20
Compare
|
SMTP errors while sending MDN will no longer result in a "red exclamation mark" on the message, but not a big deal I guess, maybe it is even better this way. |
iequidoo
approved these changes
Jun 21, 2024
link2xt
force-pushed
the
link2xt/mdn-no-message
branch
3 times, most recently
from
d692700
to
b17f913
Compare
iequidoo
reviewed
Jun 22, 2024
src/stock_str.rs
Outdated
| translated(context, StockMessage::ReadRcptMailBody) | ||
| .await | ||
| .replace1(message) | ||
| /// Stock string: `This message is a return receipt.`. |
There was a problem hiding this comment.
Should be This message is a receipt notification.
link2xt
force-pushed
the
link2xt/mdn-no-message
branch
from
b17f913
to
f215f66
Compare
iequidoo
approved these changes
Jun 23, 2024
r10s
added a commit
that referenced
this pull request
Jul 26, 2024
while adapting strings for the recent change about read receipts, #5712 , it turns out in discussions eg. at deltachat/deltachat-android#3179 that untranslated english for the read receipts seem to be sufficient or even better: - do not reveal the sender's language - unexpected languages are confusing - even if you chat in english, you may get Chinese read receipts - many clients do not show the text anyways, iirc, eg. Outlook display the read receipts in context, and Delta Chat of course as well
r10s
added a commit
that referenced
this pull request
Jul 26, 2024
while adapting strings for the recent change about read receipts, #5712 , it turns out in discussions eg. at deltachat/deltachat-android#3179 that untranslated english for the read receipts seem to be sufficient or even better: - do not reveal the sender's language - unexpected languages are confusing - even if you chat in english, you may get Chinese read receipts - many clients do not show the text anyways, iirc, eg. Outlook display the read receipts in context, and Delta Chat of course as well
r10s
added a commit
that referenced
this pull request
Jul 26, 2024
while adapting strings for the recent change about read receipts, #5712 , it turns out in discussions eg. at deltachat/deltachat-android#3179 that untranslated english for the read receipts seem to be sufficient or even better: - do not reveal the sender's language - unexpected languages are confusing - even if you chat in english, you may get Chinese read receipts - many clients do not show the text anyways, iirc, eg. Outlook display the read receipts in context, and Delta Chat of course as well - afaik, we're leaving comparable `multipart/report` untranslated as well (sync, but also webxdc updates are practically english only) - less code, fewer translations needed :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary change is in the types, moving Mimefactory.Message into
Loaded::Messagevariant.The rest is fighting borrow checker.
Fixes #5710