test(python): Wait for bot's DC_EVENT_IMAP_INBOX_IDLE before sending messages to it (#5699) #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iequidoo
commented
Jun 23, 2024
python/src/deltachat/testplugin.py
Outdated
| self._acsetup.start_configure(bot_ac) | ||
| self.wait_configured(bot_ac) | ||
| bot_ac.start_io() | ||
| # Wait for DC_EVENT_IMAP_INBOX_IDLE so that all emails received by the bot later are |
There was a problem hiding this comment.
"... appeared in the bot's Inbox later" is probably a better phrasing
…messages to it (#5699) Bot processes are run asynchronously, so we shouldn't send messages to a bot before it's fully initialised and skipped existing messages for processing, i.e. before DC_EVENT_IMAP_INBOX_IDLE is emitted.
link2xt
approved these changes
Jun 23, 2024
iequidoo
force-pushed
the
iequidoo/await-bot-imap-inbox-idle
branch
from
098f41c
to
b2ff001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot processes are run asynchronously, so we shouldn't send messages to a bot before it's fully initialised and skipped existing messages for processing, i.e. before DC_EVENT_IMAP_INBOX_IDLE is emitted.
Close #5699