Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicitly close the database on account removal #5814

Merged
merged 1 commit into from
Jul 30, 2024
Merged

fix: explicitly close the database on account removal #5814

merged 1 commit into from
Jul 30, 2024

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Jul 29, 2024

Closes #5809

@link2xt link2xt requested a review from iequidoo July 29, 2024 23:13
@link2xt
Copy link
Collaborator Author

link2xt commented Jul 29, 2024

I have tested in #5811, this actually fixed the problem. CI passed on Windows without try_many_times.

This was referenced Jul 29, 2024
Closed
Closed
Open
@link2xt link2xt merged commit 0fceb27 into main Jul 30, 2024
37 checks passed
@link2xt link2xt deleted the link2xt/close-db branch July 30, 2024 00:22
@link2xt link2xt mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iequidoo iequidoo iequidoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Database not closed immediately on account removal
2 participants
@link2xt @iequidoo