fix: use default server list for providers that don't have one #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are providers in the provider database that do not have servers specified. For such providers default list should be tried just like when configuring unknown providers.
iequidoo
reviewed
Sep 2, 2024
| ServerParams { | ||
| protocol: Protocol::Imap, | ||
| hostname: context | ||
| .get_config(Config::ConfiguredMailServer) |
There was a problem hiding this comment.
Shouldn't ConfiguredImapServers/ConfiguredSmtpServers be used instead? ConfiguredMailServer is legacy and reset to None in save_as_configured_params()
There was a problem hiding this comment.
This is for legacy configurations, so they keep using configured servers. They will not benefit from autoreconfiguration, but I am not sure trying potentially non-existing domains is better. For new setups this will be empty and expanded into example.org, mail.example.org and imap.example.org, so autoreconfiguration will try all options.
iequidoo
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are providers in the provider database
that do not have servers specified.
For such providers default list should be tried
just like when configuring unknown providers.
Closes #5937