-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ConfigSynced event #5170
Conversation
still needs cffi and jsonrpc |
We can drop the |
rather mark it first as deprecated and we remove it later unless it is not released yet. |
8a45d3b
to
5cda133
Compare
I don't like rustfmt so frequently reformatting code and messing up git history, but this time it reduced the number of LOCs, so let it be |
5cda133
to
ef0356a
Compare
If rustfmt is a problem just put |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the new event is missing in deltachat.h - even though it is not used currently, cffi is the still most complete and accurate documentation and we should maintain it for completeness. also, might be that it will become handy :)
5cda133
to
3cdde56
Compare
Add an event for a case if a multi-device synced config value changed. Maybe the app needs to refresh smth on such an event. For uniformity it is emitted on the source device too. The value is omitted, otherwise it would be logged which might not be good for privacy.
3cdde56
to
ebcd5b6
Compare
It's already the last commit in the patchset.
Thanks, forgot to add it, done. |
Merging this, it's in fact a one-line change wrt the program logic |
Add an event for a case if a multi-device synced config value changed. Maybe the app needs to refresh smth on such an event. For uniformity it is emitted on the source device too. The value is omitted, otherwise it would be logged which might not be good for privacy.
Needed for deltachat/deltachat-desktop#3624