Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle subsequent taps on profile icon #3907

Closed
r10s opened this issue Jun 6, 2024 · 3 comments · Fixed by #4166
Closed

handle subsequent taps on profile icon #3907

r10s opened this issue Jun 6, 2024 · 3 comments · Fixed by #4166
Assignees
Labels
enhancement New feature or request

Comments

@r10s
Copy link
Member

r10s commented Jun 6, 2024

when tapping the profile icon of the already selected profile (so, not the first tap to switch the profile), the profile should go back to sort of "default state", which is partly done also when switching to another profile:

  • go out of profile (already done on profile switching)
  • end search (already done on profile switching)
  • scroll up(already done on profile switching)

this makes sure, the user "sees" the unread chats when they notice the profile's badge counter.

and, it makes taps on the profle switcher predictable, the user learns to always end up in a known, standard view.

the selected account chat, however, should not be changed - if that means eg. that the archive needs to stay open, then it's that.

but if the archive is entered with no selection, subsequent taps should land in the default view.

cmp. deltachat/deltachat-ios#2125 , deltachat/deltachat-ios#2171 , comparable apps

this is a minor one, no urgency at all :)

@Simon-Laux
Copy link
Member

scroll up(already done one account switching)

where? if you mean the chatlist, then I disagree, it should scroll to the selected chat, not up.

@Simon-Laux
Copy link
Member

the selected account, however, should not be changed - if that means eg. that the archive needs to stay open, then it's that.

do you mean the selected chat? account makes little sense to me here...

@r10s
Copy link
Member Author

r10s commented Jun 6, 2024

scroll up(already done one account switching)

where? if you mean the chatlist, then I disagree, it should scroll to the selected chat, not up.

this is the current behaviour, right?

so, yes, let's keep that as is. maybe also keep archive as is.

i opened that issue mainly because of the not-ended-search, so maybe concentrate on that for now, that is mostly unquestionable.

we can then see how things feel in practise and if more is missing. i modified the original post accordingly.

to be clear: again, this is post 1.46

@r10s r10s changed the title handle subsequent taps of account icon handle subsequent taps on profile icon Jun 6, 2024
@Simon-Laux Simon-Laux assigned Simon-Laux and unassigned Simon-Laux Oct 3, 2024
Simon-Laux added a commit that referenced this issue Oct 3, 2024
Simon-Laux added a commit that referenced this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants