-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'realtime channel' experimental option not persisted #3990
Labels
bug
Something isn't working
Comments
Same for me on Ubuntu/Linux install that the webxdc-realtime setting is not persisted.
Restarting desktop reliably reset the "on" setting.
…On Mon, Jul 01, 2024 at 02:19 -0700, bjoern wrote:
enabling experimental 'realtime webxdc channels' option is not persisted for me on mac using dc 1.46.1 - had a hard time until i realise that, i was always thinking the [ongoing iOS implementation](deltachat/deltachat-ios#2225) is doing sth wrong ..
is it only me? i cannot really believe this is a general issue.
https://github.com/deltachat/deltachat-desktop/assets/9800740/9501bdcb-17b8-4b46-986b-07cd11af4e62
|
fixed by #3992 |
Merged
WofWca
added a commit
that referenced
this issue
Jul 1, 2024
To avoid issues like #3990 This ensures that the type and the array always have the same keys
WofWca
added a commit
that referenced
this issue
Jul 1, 2024
To avoid issues like #3990 This ensures that the type and the array always have the same keys However, simply adding an extra property on `SettingsValues` will not cause errors, it will simply keep the `SettingsStoreState` type unchanged. But any runtime changes (e.g. adding or accessing a property without also adding it to the array, or vice versa) will be caught.
Simon-Laux
pushed a commit
that referenced
this issue
Jul 1, 2024
To avoid issues like #3990 This ensures that the type and the array always have the same keys However, simply adding an extra property on `SettingsValues` will not cause errors, it will simply keep the `SettingsStoreState` type unchanged. But any runtime changes (e.g. adding or accessing a property without also adding it to the array, or vice versa) will be caught.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
enabling experimental 'realtime webxdc channels' option is not persisted for me on mac using dc 1.46.1 - had a hard time until i realise that, i was always thinking the ongoing iOS implementation is doing sth wrong 😂
is it only me? i cannot really believe this is a general issue :)
Screen.Recording.2024-07-01.at.11.14.00.mov
The text was updated successfully, but these errors were encountered: