Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'realtime channel' experimental option not persisted #3990

Closed
r10s opened this issue Jul 1, 2024 · 2 comments
Closed

'realtime channel' experimental option not persisted #3990

r10s opened this issue Jul 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@r10s
Copy link
Member

r10s commented Jul 1, 2024

enabling experimental 'realtime webxdc channels' option is not persisted for me on mac using dc 1.46.1 - had a hard time until i realise that, i was always thinking the ongoing iOS implementation is doing sth wrong 😂

is it only me? i cannot really believe this is a general issue :)

Screen.Recording.2024-07-01.at.11.14.00.mov
@r10s r10s added the bug Something isn't working label Jul 1, 2024
@hpk42
Copy link
Contributor

hpk42 commented Jul 1, 2024 via email

@hpk42
Copy link
Contributor

hpk42 commented Jul 1, 2024

fixed by #3992

@hpk42 hpk42 closed this as completed Jul 1, 2024
WofWca added a commit that referenced this issue Jul 1, 2024
To avoid issues like #3990
WofWca added a commit that referenced this issue Jul 1, 2024
To avoid issues like #3990
WofWca added a commit that referenced this issue Jul 1, 2024
To avoid issues like #3990

This ensures that the type and the array always have the same keys
WofWca added a commit that referenced this issue Jul 1, 2024
To avoid issues like #3990

This ensures that the type and the array always have the same keys

However, simply adding an extra property on `SettingsValues`
will not cause errors, it will simply keep
the `SettingsStoreState` type unchanged.
But any runtime changes (e.g. adding or accessing a property
without also adding it to the array, or vice versa) will be caught.
Simon-Laux pushed a commit that referenced this issue Jul 1, 2024
To avoid issues like #3990

This ensures that the type and the array always have the same keys

However, simply adding an extra property on `SettingsValues`
will not cause errors, it will simply keep
the `SettingsStoreState` type unchanged.
But any runtime changes (e.g. adding or accessing a property
without also adding it to the array, or vice versa) will be caught.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants