Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first prototype of highlight qr codes in fullscreen image view #3346

Closed
wants to merge 2 commits into from

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Aug 6, 2023

  • icon button to toggle
  • handle window resize (ideally only change scaling without looking for qrcodes again) - test in both directions height and width
  • correct positioning -> still has bugs getting the correct scaling sometimes
  • nice design
  • context menu -> does not open, somehow the other context menu blocks it (maybe the pan library?? or react?)
  • click to open link
  • if user opens internal link then close the fullscreen media view when user takes an action that justifies it. (join group, create new account and so on)
  • for the enum in the wasm qr code scanner I might need it in another serde variant representation, ts does not like the current one
  • bonus: 3D perspective for qr code highlight
  • better detection with other or hybrid (use 2 libs at the same time) library
  • worker thread (don't block ui)

@Simon-Laux Simon-Laux added the enhancement New feature or request label Aug 6, 2023
@Simon-Laux Simon-Laux closed this Sep 28, 2023
@hpk42
Copy link
Contributor

hpk42 commented Sep 28, 2023 via email

@Simon-Laux
Copy link
Member Author

Simon-Laux commented Sep 28, 2023

could you state a little summary/rationale for closing?

out of scope for now. so moved to resurrection. Qr scanner is not good enough yet in my opinion. Also see todos.

@Simon-Laux Simon-Laux mentioned this pull request Apr 10, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Closed PRs and Issues
Development

Successfully merging this pull request may close these issues.

2 participants