Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show prettier linter warnings through eslint #3463

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Conversation

adzialocha
Copy link
Member

@adzialocha adzialocha commented Nov 2, 2023

This PR installs the eslint-plugin-prettier package and enables prettier-related linting warnings through eslint.

I prefer to see prettier style violations directly in my IDE (neovim in that case) and use the automatic fixing feature as a part of it, but also happy to find another approach if there are any recommendations.

Before:

screenshot-2023-11-02T15:10:43

After:

screenshot-2023-11-02T15:11:24

Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adzialocha adzialocha changed the title Show linter warnings on prettier violations Show eslint warnings on prettier violations Nov 2, 2023
@adzialocha adzialocha changed the title Show eslint warnings on prettier violations Show prettier linter warnings through eslint Nov 2, 2023
@adzialocha adzialocha marked this pull request as ready for review November 2, 2023 14:18
@Simon-Laux Simon-Laux merged commit cad9b8a into master Nov 2, 2023
8 checks passed
@Simon-Laux Simon-Laux deleted the prettier-warn branch November 2, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants