Show vcard in messages #3840
Show vcard in messages #3840
Conversation
|
Something seems to be wrong with the prettier check: local check shows no errors, the errors displayed here like |
| <div | ||
| className={classNames('avatar', styles.avatar)} | ||
| aria-label={displayName} | ||
| > |
There was a problem hiding this comment.
I think it makes sense to use the same Avatar component as chatlist?
There was a problem hiding this comment.
Yes I agree, but then we have to change the line <img className='content' src={'file://' + avatarPath} /> there, since the profileImage is base64 encoded. Will do that later...
was a prettier (formatting error) on main branch that got carried into your branch, it was complaining about double quotes vs single quotes. nothing to do with your pr. the error now about misplaced console.log is also about an issue on the main branch which was solved in the meantime, somehow the ci is not run anymore on the main branch, maybe related to renaming it, I'll investigate. |
|
Display in stage, replies, drafts etc. uses just the currently provided stuff from core, which might be improved in future |
| @@ -586,6 +589,11 @@ export default function Message(props: { | |||
| const hasText = text !== null && text !== '' | |||
| const fileMime = (!isSetupmessage && message.fileMime) || null | |||
| const isWithoutText = isMediaWithoutText(fileMime, hasText, message.viewType) | |||
| const showAttachment = (message: T.Message) => | |||
There was a problem hiding this comment.
showAttachment as function sounds like an action, maybe rename it to sth like shouldShowAttachment or make it a variable/const instead of a function?
CHANGELOG.md
Outdated
| - show VCard attachement as VCard in message list | ||
| - add contact from VCard & start chat on click |
There was a problem hiding this comment.
needs to be rebased / not be in the old/already released version
resolves #3829
- add click handler to start chat
Simon-Laux
force-pushed
the
ndh/task-3829-viewtype-vcard
branch
from
3211415
to
39ce931
Compare
resolves #3829