Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code at mailadm setup-bot is broken #105

Closed
missytake opened this issue Feb 1, 2023 · 3 comments · Fixed by #106
Closed

QR code at mailadm setup-bot is broken #105

missytake opened this issue Feb 1, 2023 · 3 comments · Fixed by #106
Labels
bug Something isn't working

Comments

@missytake
Copy link
Contributor

When you run mailadm setup-bot, a QR code is shown, and an OPENPGP4FPR token which is supposed to be encoded in the QR code. This encoding doesn't work anymore, and the Delta Chat QR code scanner doesn't recognize it as a valid QR code anymore, neither do other online scanners like https://scanqr.org/. I suspect the new https://pypi.org/project/qrcode/#history release from yesterday, but let's investigate properly. try.webxdc.org still works, as a reference.

  • Operating System (Linux/Mac/Windows/iOS/Android):
  • Delta Chat Version:
  • Expected behavior:
  • Actual behavior:
  • Steps to reproduce the problem:
  • Screenshots:
  • Logs:
@missytake missytake added the bug Something isn't working label Feb 1, 2023
@missytake
Copy link
Contributor Author

As a workaround, you can just copy-paste the OPENPGP4FPR token into the QR code scanner of the Delta Chat desktop client for now.

@missytake
Copy link
Contributor Author

Shit, the same seems to be the case for the user adding QR codes.

@missytake
Copy link
Contributor Author

Version 7.4.0 of the https://pypi.org/project/qrcode/#history library has introduced a bug, resulting in all QR codes mailadm generates being unreadable. We discovered this during a live test with users, very unfortunate.

I pushed a hotfix to master yesterday, pinning the qrcode version to 7.3.1 :) so it works again.

As soon as there is a working 7.4.1 release with a fix, #106 reverts the hotfix and introduces a test for our gen_qr() function, which was untested so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant