Do not lock the database during pruning #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
link2xt
force-pushed
the
cleanup-threads
branch
from
bd9040b
to
6c5ba52
Compare
link2xt
force-pushed
the
link2xt/prune-dont-lock-the-database
branch
from
00a5c8d
to
d0649b4
Compare
link2xt
force-pushed
the
link2xt/prune-dont-lock-the-database
branch
from
d0649b4
to
e045cac
Compare
Pruning does network requests like calling the mailcow API. Holding the database write transaction for the duration of pruning is dangerous, because it may delay creating a new account in the new_email endpoint or make it timeout.
link2xt
force-pushed
the
link2xt/prune-dont-lock-the-database
branch
from
e045cac
to
293a742
Compare
|
Closed in favor of #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pruning does network requests like calling the mailcow API. Holding the database write transaction for the duration of pruning is dangerous, because it may delay creating a new account in the new_email endpoint or make it timeout.
Fixes #72