Log the exception if bot fails

[link2xt]

No description provided.

[missytake]

Hm, doesn't work for me - I raised a ValueError somewhere in the code, but the output just said:

2022-12-30T22:10:30.773533816Z 0.01 [events-bot] DC_EVENT_INFO data1=0 data2=src/scheduler.rs:324: starting smtp loop
2022-12-30T22:10:30.773821563Z 0.01 [events-bot] DC_EVENT_INFO data1=0 data2=src/scheduler.rs:517: scheduler is running
2022-12-30T22:10:30.774288545Z 0.01 [events-bot] DC_EVENT_INFO data1=0 data2=src/location.rs:603: Location loop is waiting for 24h 0m 0s or interrupt
2022-12-30T22:10:30.777363951Z bot received an unexpected error , exiting now
2022-12-30T22:10:30.777424861Z 0.01 [events-bot] DC_EVENT_INFO data1=0 data2=src/ephemeral.rs:544: Ephemeral loop waiting for deletion in 24h 0m 0s or interrupt

[link2xt]

@missytake I pushed another commit to format with repr(), so it also prints the error class. But otherwise it's ok that ValueError() is formatted like this:

>>> print(ValueError())

>>>

[missytake]

2022-12-30T22:46:19.788044943Z 0.00 [events-bot] DC_EVENT_INFO data1=0 data2=src/location.rs:603: Location loop is waiting for 24h 0m 0s or interrupt
2022-12-30T22:46:19.793593927Z 0.01 [events-bot] DC_EVENT_INFO data1=0 data2=src/contact.rs:1518: Recently seen loop waiting for 24h 0m 0s or interupt
2022-12-30T22:46:19.795321201Z bot received an unexpected error ValueError(), exiting now

Hm, that's a bit better, but can't we log the whole stacktrace? Without the stacktrace it's not very useful.

[missytake]

What about this:

>>> import traceback
>>> try:
...     raise ValueError
... finally:
...     strin = traceback.format_exc()
...     print("tb:", strin)
... 
tb: Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
ValueError

Traceback (most recent call last):
  File "<stdin>", line 2, in <module>
ValueError

[link2xt]

I did it with logging now, what do you think?

[missytake]

Looks good now! We could aaaalso make a finally out of it again instead of except, then my IDE doesn't complain about the "too broad exception clause" ;) but except fits as well.

[link2xt]

Exception is probably not accessible from the finally block, because finally runs also when there is no exception.

[missytake]

because finally runs also when there is no exception.

It doesn't, if only because there is a while 1 in the try clause :D but yes, using except fits better then.