Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the usability for incorporating multiple map tile services #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imysl0
Copy link

@imysl0 imysl0 commented Jun 12, 2024

  1. Add the mapServices.js file to facilitate the easier addition of map providers.
  2. Include a dropdown menu to conveniently select different tile services.
    图片 图片

…ap providers.

2. Include a dropdown menu to conveniently select different tile services.
Copy link
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test yet

@Simon-Laux
Copy link
Member

Simon-Laux commented Sep 27, 2024

maybe save last selected tile provider in LocalStorage?

Also we could whitelist all those providers as a temporary fix in deltachat desktop:

const hostRules = 'MAP * ~NOTFOUND, EXCLUDE *.openstreetmap.org, EXCLUDE tile.openstreetmap.org, EXCLUDE *.tile.osm.org, EXCLUDE *.tile.openstreetmap.de, EXCLUDE *.tile.openstreetmap.fr, EXCLUDE *.tile.opentopomap.org, EXCLUDE *.is.autonavi.com, EXCLUDE tm.amap.com, EXCLUDE *.map.gtimg.com, EXCLUDE *.tianditu.gov.cn'

But for a more permanent solution I'd prefer if those requests go over delta chat core (http request api), so that they respect proxy settings for that account.

@imysl0
Copy link
Author

imysl0 commented Oct 13, 2024

maybe save last selected tile provider in LocalStorage?

Also we could whitelist all those providers as a temporary fix in deltachat desktop:

const hostRules = 'MAP * ~NOTFOUND, EXCLUDE *.openstreetmap.org, EXCLUDE tile.openstreetmap.org, EXCLUDE *.tile.osm.org, EXCLUDE *.tile.openstreetmap.de, EXCLUDE *.tile.openstreetmap.fr, EXCLUDE *.tile.opentopomap.org, EXCLUDE *.is.autonavi.com, EXCLUDE tm.amap.com, EXCLUDE *.map.gtimg.com, EXCLUDE *.tianditu.gov.cn'

But for a more permanent solution I'd prefer if those requests go over delta chat core (http request api), so that they respect proxy settings for that account.

Hi Simon:
Both suggestions are pretty good, but I'm still not sure how to proceed, because I'm not a programmer. The previous code was also written with the help of AI. Let me think about it (maybe wait for AI to improve a bit, hahaha).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants