Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: pagination issues with hypermedia controls for LDF. #154

Merged
merged 1 commit into from
May 11, 2022

Conversation

kiivihal
Copy link
Member

The pagerURI was not always set correctly, which causes the pagination to revert to all triples in some cases.

pagerURI was not always set correctly.
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
36.3% 36.3% Duplication

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #154 (f824ffd) into main (d6d023a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
- Coverage   29.60%   29.60%   -0.01%     
==========================================
  Files         194      194              
  Lines       17430    17441      +11     
==========================================
+ Hits         5160     5163       +3     
- Misses      11899    11907       +8     
  Partials      371      371              
Flag Coverage Δ
unittests 29.60% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub3/fragments/hypermedia.go 71.11% <100.00%> (-5.36%) ⬇️
ikuzo/server.go 76.66% <0.00%> (-2.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d023a...f824ffd. Read the comment docs.

@kiivihal kiivihal merged commit 80ae955 into main May 11, 2022
@kiivihal kiivihal deleted the feature/hypermedia-controls branch May 11, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant