Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set modified when indexing fragments.FragmentGraph. #158

Merged
merged 3 commits into from
May 30, 2022

Conversation

kiivihal
Copy link
Member

This can be used for oaipmh or sitemap services in the future.

This allows one default to be set for many different urls. This should
only be used when there is only a single organization configured.
This can be used for oaipmh or sitemap services in the future.
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #158 (6c4db5f) into main (92ed427) will increase coverage by 0.00%.
The diff coverage is 61.11%.

❗ Current head 6c4db5f differs from pull request most recent head afeeb1c. Consider uploading reports for the commit afeeb1c to get more accurate results

@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   29.69%   29.70%           
=======================================
  Files         195      195           
  Lines       17472    17475    +3     
=======================================
+ Hits         5189     5191    +2     
- Misses      11910    11912    +2     
+ Partials      373      372    -1     
Flag Coverage Δ
unittests 29.70% <61.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hub3/fragments/api.go 23.10% <0.00%> (-0.02%) ⬇️
ikuzo/domain/organization.go 51.61% <ø> (ø)
ikuzo/service/organization/middleware.go 0.00% <0.00%> (ø)
ikuzo/service/x/bulk/request.go 0.00% <0.00%> (ø)
hub3/fragments/resource.go 24.01% <33.33%> (+0.18%) ⬆️
ikuzo/domain/hub_id.go 90.90% <90.90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ed427...afeeb1c. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kiivihal kiivihal merged commit a734150 into main May 30, 2022
@kiivihal kiivihal deleted the feature/fragmentgraph-modified branch May 30, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant