Dependabot configuration and security fixes #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiivihal
force-pushed
the
feature/v0.3/security-fixes-dependencies
branch
from
e560b6a
to
d875e4f
Compare
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 29.13% 29.10% -0.04%
==========================================
Files 203 203
Lines 18151 18163 +12
==========================================
- Hits 5289 5287 -2
- Misses 12476 12489 +13
- Partials 386 387 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -208,7 +208,7 @@ | |||
| case strings.Contains(r.URL.EscapedPath(), "v2") || strings.Contains(r.URL.EscapedPath(), "v1"): | |||
| // direct access on get is allowed via the proxy on v2 indices | |||
| case !strings.HasPrefix(r.URL.EscapedPath(), "/_cat"): | |||
| http.Error(w, fmt.Sprintf("path %s is not allowed on esProxy", r.URL.EscapedPath()), http.StatusBadRequest) | |||
| http.Error(w, fmt.Sprintf("path %q is not allowed on esProxy", r.URL.EscapedPath()), http.StatusBadRequest) | |||
Check warning
Code scanning / CodeQL
Reflected cross-site scripting
* WIP: misc fixes to support harvesting from WikiBase sparql endpoint. * update .gitignore * Cleanup the test and added wikibase test data.
* HUB-450: added sublogger functionality * HUB-226: added source to DaoConfig * defaultimagepath * no-return * no-return-2 * HUB-470: http response code 200 instead of 500 for deleting mets endpoint * file gets deleted even when not in elasticsearch * delete mets with source path * delete mets on sourcepath + * return error in case of file not found * HUB-486 start cannot be greater than end * end = 0 om het einde op te vragen * review comments Co-authored-by: bbimmerman <bram.bimmerman@nationaalarchief.nl> Co-authored-by: Sjoerd Siebinga <sjoerd.siebinga@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
kiivihal
added a commit
that referenced
this pull request
Aug 31, 2022
* fixes: for dependabot codescanning issues. * added github workflow configurations for codeql and dependency-review * fixes: update namespace tests and configuration. * update go mod * update go dependecies. * update go dependecies. * fixed upgrade issues with gitea library. * misc fixes to support harvesting from WikiBase sparql endpoint. (#168) * WIP: misc fixes to support harvesting from WikiBase sparql endpoint. * update .gitignore * Cleanup the test and added wikibase test data. * Feature/mets logging (#164) * HUB-450: added sublogger functionality * HUB-226: added source to DaoConfig * defaultimagepath * no-return * no-return-2 * HUB-470: http response code 200 instead of 500 for deleting mets endpoint * file gets deleted even when not in elasticsearch * delete mets with source path * delete mets on sourcepath + * return error in case of file not found * HUB-486 start cannot be greater than end * end = 0 om het einde op te vragen * review comments Co-authored-by: bbimmerman <bram.bimmerman@nationaalarchief.nl> Co-authored-by: Sjoerd Siebinga <sjoerd.siebinga@gmail.com> Co-authored-by: Wouter Pluut <wouter.pluut@pluut.nl> Co-authored-by: bbimmerman <bram.bimmerman@nationaalarchief.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request updates the configuration of how pull-requests are scanned for vulnerabilities.
Until nats is replaces we will have to force merging requests, because we can't upgrade the current NATS versions without a refactor. This seems a waste of time, since we are going to replace it anyway.