Rename deploy

[jalextowle]

Description

Rename deploy to either deployHyperdrive or deployTarget

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can
be removed.

[[Reviewer Name]]

• Tokens
  • Do all approve calls use forceApprove?
  • Do all transfer calls use safeTransfer?
  • Do all transferFrom calls use msg.sender as the from address?
    • If not, is the function access restricted to prevent unauthorized
      token spend?
• Low-level calls (call, delegatecall, staticcall, transfer, send)
  • Is the returned success boolean checked to handle failed calls?
  • If using delegatecall, are there strict access controls on the
    addresses that can be called? It shouldn't be possible to delegatecall
    arbitrary addresses, so the list of possible targets should either be
    immutable or tightly controlled by an admin.
• Reentrancy
  • Are functions that make external calls or transfer ether marked as nonReentrant?
    • If not, is there documentation that explains why reentrancy is
      not a concern or how it's mitigated?
• Gas Optimizations
  • Is the logic as simple as possible?
  • Are the storage values that are used repeatedly cached in stack or
    memory variables?
  • If loops are used, are there guards in place to avoid out-of-gas
    issues?
• Visibility
  • Are all payable functions restricted to avoid stuck ether?
• Math
  • Is all of the arithmetic checked or guarded by if-statements that will
    catch underflows?
  • If Safe functions are altered, are potential underflows and
    overflows caught so that a failure flag can be thrown?
  • Are all of the rounding directions clearly documented?
• Testing
  • Are there new or updated unit or integration tests?
  • Do the tests cover the happy paths?
  • Do the tests cover the unhappy paths?
  • Are there an adequate number of fuzz tests to ensure that we are
    covering the full input space?

[slundqui]

LGTM

[coveralls]

Pull Request Test Coverage Report for Build 8946045386

Details

• 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 93.235%

---

Totals
Change from base Build 8945345065:	0.0%
Covered Lines:	1833
Relevant Lines:	1966

---

💛 - Coveralls

[github-actions]

Hyperdrive Gas Benchmark

Benchmark suite	Current: 664b3fe	Previous: a74a586	Deviation	Status
addLiquidity: min	33827 gas	33827 gas	0%	🟰
addLiquidity: avg	156773 gas	156478 gas	0.1885%	🚨
addLiquidity: max	428439 gas	428439 gas	0%	🟰
checkpoint: min	40270 gas	40270 gas	0%	🟰
checkpoint: avg	142253 gas	142320 gas	-0.0471%	✅
checkpoint: max	253402 gas	253402 gas	0%	🟰
closeLong: min	31361 gas	31361 gas	0%	🟰
closeLong: avg	135387 gas	135287 gas	0.0739%	🚨
closeLong: max	2625774 gas	2625774 gas	0%	🟰
closeShort: min	31349 gas	31349 gas	0%	🟰
closeShort: avg	131675 gas	131622 gas	0.0403%	🚨
closeShort: max	262932 gas	262932 gas	0%	🟰
initialize: min	31371 gas	31371 gas	0%	🟰
initialize: avg	330250 gas	330317 gas	-0.0203%	✅
initialize: max	396281 gas	396281 gas	0%	🟰
openLong: min	33370 gas	33370 gas	0%	🟰
openLong: avg	173420 gas	173342 gas	0.0450%	🚨
openLong: max	306679 gas	306679 gas	0%	🟰
openShort: min	33936 gas	33936 gas	0%	🟰
openShort: avg	168079 gas	167949 gas	0.0774%	🚨
openShort: max	414945 gas	412493 gas	0.5944%	🚨
redeemWithdrawalShares: min	31251 gas	31251 gas	0%	🟰
redeemWithdrawalShares: avg	74861 gas	74747 gas	0.1525%	🚨
redeemWithdrawalShares: max	209762 gas	209762 gas	0%	🟰
removeLiquidity: min	31301 gas	31301 gas	0%	🟰
removeLiquidity: avg	208737 gas	209212 gas	-0.2270%	✅
removeLiquidity: max	403586 gas	403586 gas	0%	🟰

This comment was automatically generated by workflow using github-action-benchmark.